Tweak
Brian Vaughn committed
May 22, 2019 at 16:40 UTC
98623dfdb007933ff4c38052f2827a74fc9b5a4a
1 file changed
+15
-20
src/backend/agent.js
+15
-20
@@ -373,10 +373,11 @@ export default class Agent extends EventEmitter {
373
374
startInspectingDOM = () => {
375
window.addEventListener('click', this._onClick, true);
376
- window.addEventListener('mousedown', this._onMouseDown, true);
377
- window.addEventListener('mouseup', this._onMouseUp, true);
378
- window.addEventListener('pointerover', this._onPointerOver, true);
376
+ window.addEventListener('mousedown', this._onMouseEvent, true);
377
+ window.addEventListener('mouseover', this._onMouseEvent, true);
378
+ window.addEventListener('mouseup', this._onMouseEvent, true);
379
window.addEventListener('pointerdown', this._onPointerDown, true);
380
+ window.addEventListener('pointerover', this._onPointerOver, true);
381
window.addEventListener('pointerup', this._onPointerUp, true);
382
};
383
@@ -395,10 +396,11 @@ export default class Agent extends EventEmitter {
396
hideOverlay();
397
398
window.removeEventListener('click', this._onClick, true);
398
- window.removeEventListener('mousedown', this._onMouseDown, true);
399
- window.removeEventListener('mouseup', this._onMouseUp, true);
400
- window.removeEventListener('pointerover', this._onPointerOver, true);
399
+ window.removeEventListener('mousedown', this._onMouseEvent, true);
400
+ window.removeEventListener('mouseover', this._onMouseEvent, true);
401
+ window.removeEventListener('mouseup', this._onMouseEvent, true);
402
window.removeEventListener('pointerdown', this._onPointerDown, true);
403
+ window.removeEventListener('pointerover', this._onPointerOver, true);
404
window.removeEventListener('pointerup', this._onPointerUp, true);
405
};
406
@@ -490,10 +492,11 @@ export default class Agent extends EventEmitter {
492
event.stopPropagation();
493
494
this.stopInspectingDOM();
495
+
496
this._bridge.send('stopInspectingDOM', true);
497
};
498
496
- _onMouseDown = (event: MouseEvent) => {
499
+ _onMouseEvent = (event: MouseEvent) => {
500
event.preventDefault();
501
event.stopPropagation();
502
};
@@ -505,19 +508,6 @@ export default class Agent extends EventEmitter {
508
this._selectFiberForNode(((event.target: any): HTMLElement));
509
};
510
508
- // While we don't do anything here, this makes choosing
509
- // the inspected element less invasive and less likely
510
- // to dismiss e.g. a context menu.
511
- _onMouseUp = (event: MouseEvent) => {
512
- event.preventDefault();
513
- event.stopPropagation();
514
- };
515
-
516
- _onPointerUp = (event: MouseEvent) => {
517
- event.preventDefault();
518
- event.stopPropagation();
519
- };
520
-
511
_onPointerOver = (event: MouseEvent) => {
512
event.preventDefault();
513
event.stopPropagation();
@@ -531,6 +521,11 @@ export default class Agent extends EventEmitter {
521
this._selectFiberForNode(target);
522
};
523
524
+ _onPointerUp = (event: MouseEvent) => {
525
+ event.preventDefault();
526
+ event.stopPropagation();
527
+ };
528
+
529
_selectFiberForNode = throttle(
530
memoize((node: HTMLElement) => {
531
const id = this.getIDForNode(node);