Remove enableUserBlockingEvents flag (#16882)
Seems like this worked out. We can clean up the flag now.
Sebastian Markbåge committed
Sep 27, 2019 at 19:46 UTC
9d637844e9761a29a49bc53a9b41244d683f89e3
14 files changed
+11
-44
packages/react-dom/src/events/DOMEventResponderSystem.js
+3
-8
@@ -39,7 +39,6 @@ import {
39
UserBlockingEvent,
40
DiscreteEvent,
41
} from 'shared/ReactTypes';
42
-import {enableUserBlockingEvents} from 'shared/ReactFeatureFlags';
42
43
// Intentionally not named imports because Rollup would use dynamic dispatch for
44
// CommonJS interop named imports.
@@ -104,13 +103,9 @@ const eventResponderContext: ReactDOMResponderContext = {
103
break;
104
}
105
case UserBlockingEvent: {
107
- if (enableUserBlockingEvents) {
108
- runWithPriority(UserBlockingPriority, () =>
109
- executeUserEventHandler(eventListener, eventValue),
110
- );
111
- } else {
112
- executeUserEventHandler(eventListener, eventValue);
113
- }
106
+ runWithPriority(UserBlockingPriority, () =>
107
+ executeUserEventHandler(eventListener, eventValue),
108
+ );
109
break;
110
}
111
case ContinuousEvent: {
packages/react-dom/src/events/ReactDOMEventListener.js
+5
-12
@@ -62,10 +62,7 @@ import SimpleEventPlugin from './SimpleEventPlugin';
62
import {getRawEventName} from './DOMTopLevelEventTypes';
63
import {passiveBrowserEventsSupported} from './checkPassiveEvents';
64
65
-import {
66
- enableFlareAPI,
67
- enableUserBlockingEvents,
68
-} from 'shared/ReactFeatureFlags';
65
+import {enableFlareAPI} from 'shared/ReactFeatureFlags';
66
import {
67
UserBlockingEvent,
68
ContinuousEvent,
@@ -298,14 +295,10 @@ function dispatchUserBlockingUpdate(
295
eventSystemFlags,
296
nativeEvent,
297
) {
301
- if (enableUserBlockingEvents) {
302
- runWithPriority(
303
- UserBlockingPriority,
304
- dispatchEvent.bind(null, topLevelType, eventSystemFlags, nativeEvent),
305
- );
306
- } else {
307
- dispatchEvent(topLevelType, eventSystemFlags, nativeEvent);
308
- }
298
+ runWithPriority(
299
+ UserBlockingPriority,
300
+ dispatchEvent.bind(null, topLevelType, eventSystemFlags, nativeEvent),
301
+ );
302
}
303
304
function dispatchEventForPluginEventSystem(
packages/react-dom/src/events/__tests__/ChangeEventPlugin-test.internal.js
-2
@@ -750,8 +750,6 @@ describe('ChangeEventPlugin', () => {
750
it('mouse enter/leave should be user-blocking but not discrete', async () => {
751
// This is currently behind a feature flag
752
jest.resetModules();
753
- ReactFeatureFlags = require('shared/ReactFeatureFlags');
754
- ReactFeatureFlags.enableUserBlockingEvents = true;
753
React = require('react');
754
ReactDOM = require('react-dom');
755
TestUtils = require('react-dom/test-utils');
packages/react-interactions/events/src/dom/__tests__/Hover-test.internal.js
-1
@@ -22,7 +22,6 @@ function initializeModules(hasPointerEvents) {
22
setPointerEvent(hasPointerEvents);
23
ReactFeatureFlags = require('shared/ReactFeatureFlags');
24
ReactFeatureFlags.enableFlareAPI = true;
25
- ReactFeatureFlags.enableUserBlockingEvents = true;
25
React = require('react');
26
ReactDOM = require('react-dom');
27
HoverResponder = require('react-interactions/events/hover').HoverResponder;
packages/react-interactions/events/src/dom/__tests__/Input-test.internal.js
-1
@@ -35,7 +35,6 @@ const modulesInit = () => {
35
ReactFeatureFlags = require('shared/ReactFeatureFlags');
36
ReactFeatureFlags.enableFlareAPI = true;
37
ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;
38
- ReactFeatureFlags.enableUserBlockingEvents = true;
38
React = require('react');
39
ReactDOM = require('react-dom');
40
Scheduler = require('scheduler');
packages/react-interactions/events/src/dom/__tests__/MixedResponders-test-internal.js
-1
@@ -236,7 +236,6 @@ describe('mixing responders with the heritage event system', () => {
236
describe('mixing the Input and Press repsonders', () => {
237
it('is async for non-input events', () => {
238
ReactFeatureFlags.debugRenderPhaseSideEffectsForStrictMode = false;
239
- ReactFeatureFlags.enableUserBlockingEvents = true;
239
const useTap = require('react-interactions/events/tap').useTap;
240
const useInput = require('react-interactions/events/input').useInput;
241
const root = ReactDOM.unstable_createRoot(container);
packages/react-native-renderer/src/ReactFabricEventResponderSystem.js
+3
-8
@@ -31,7 +31,6 @@ import {
31
UserBlockingEvent,
32
DiscreteEvent,
33
} from './ReactNativeTypes';
34
-import {enableUserBlockingEvents} from 'shared/ReactFeatureFlags';
34
import warning from 'shared/warning';
35
import invariant from 'shared/invariant';
36
@@ -95,13 +94,9 @@ const eventResponderContext: ReactNativeResponderContext = {
94
break;
95
}
96
case UserBlockingEvent: {
98
- if (enableUserBlockingEvents) {
99
- runWithPriority(UserBlockingPriority, () =>
100
- executeUserEventHandler(eventListener, eventValue),
101
- );
102
- } else {
103
- executeUserEventHandler(eventListener, eventValue);
104
- }
97
+ runWithPriority(UserBlockingPriority, () =>
98
+ executeUserEventHandler(eventListener, eventValue),
99
+ );
100
break;
101
}
102
case ContinuousEvent: {
packages/shared/ReactFeatureFlags.js
-5
@@ -80,11 +80,6 @@ export const warnAboutUnmockedScheduler = false;
80
// *except* in some of our own tests, where we test incremental loading states.
81
export const flushSuspenseFallbacksInTests = true;
82
83
-// Changes priority of some events like mousemove to user-blocking priority,
84
-// but without making them discrete. The flag exists in case it causes
85
-// starvation problems.
86
-export const enableUserBlockingEvents = false;
87
-
83
// Add a callback property to suspense to notify which promises are currently
84
// in the update queue. This allows reporting and tracing of what is causing
85
// the user to see a loading state.
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -38,7 +38,6 @@ export const enableScopeAPI = false;
38
export const enableJSXTransformAPI = false;
39
export const warnAboutUnmockedScheduler = true;
40
export const flushSuspenseFallbacksInTests = true;
41
-export const enableUserBlockingEvents = false;
41
export const enableSuspenseCallback = false;
42
export const warnAboutDefaultPropsOnFunctionComponents = false;
43
export const warnAboutStringRefs = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -33,7 +33,6 @@ export const enableScopeAPI = false;
33
export const enableJSXTransformAPI = false;
34
export const warnAboutUnmockedScheduler = false;
35
export const flushSuspenseFallbacksInTests = true;
36
-export const enableUserBlockingEvents = false;
36
export const enableSuspenseCallback = false;
37
export const warnAboutDefaultPropsOnFunctionComponents = false;
38
export const warnAboutStringRefs = false;
packages/shared/forks/ReactFeatureFlags.persistent.js
-1
@@ -33,7 +33,6 @@ export const enableScopeAPI = false;
33
export const enableJSXTransformAPI = false;
34
export const warnAboutUnmockedScheduler = true;
35
export const flushSuspenseFallbacksInTests = true;
36
-export const enableUserBlockingEvents = false;
36
export const enableSuspenseCallback = false;
37
export const warnAboutDefaultPropsOnFunctionComponents = false;
38
export const warnAboutStringRefs = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -33,7 +33,6 @@ export const enableScopeAPI = false;
33
export const enableJSXTransformAPI = false;
34
export const warnAboutUnmockedScheduler = false;
35
export const flushSuspenseFallbacksInTests = true;
36
-export const enableUserBlockingEvents = false;
36
export const enableSuspenseCallback = false;
37
export const warnAboutDefaultPropsOnFunctionComponents = false;
38
export const warnAboutStringRefs = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -31,7 +31,6 @@ export const enableScopeAPI = true;
31
export const enableJSXTransformAPI = true;
32
export const warnAboutUnmockedScheduler = true;
33
export const flushSuspenseFallbacksInTests = true;
34
-export const enableUserBlockingEvents = false;
34
export const enableSuspenseCallback = true;
35
export const warnAboutDefaultPropsOnFunctionComponents = false;
36
export const warnAboutStringRefs = false;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -39,7 +39,6 @@ export const disableLegacyContext = false;
39
export const warnAboutStringRefs = false;
40
export const warnAboutDefaultPropsOnFunctionComponents = false;
41
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
42
-export const enableUserBlockingEvents = true;
42
43
export const enableStableConcurrentModeAPIs = false;
44