fix: ensure when-rendered content is never hidden
Justin Grant committed
Jun 15, 2019 at 09:24 UTC
a15f77670845ee667c09a0a8b74339c565eb6af2
2 files changed
+10
-3
src/devtools/views/Profiler/SidebarSelectedFiberInfo.css
+7
@@ -10,6 +10,13 @@
10
.Content {
11
padding: 0.5rem;
12
user-select: none;
13
+}
14
+
15
+.ContentShort {
16
+ overflow-y: visible;
17
+}
18
+
19
+.ContentMaybeLong {
20
overflow-y: auto;
21
}
22
src/devtools/views/Profiler/SidebarSelectedFiberInfo.js
+3
-3
@@ -74,7 +74,7 @@ export default function SidebarSelectedFiberInfo(_: Props) {
74
profilerStore={profilerStore}
75
rootID={((rootID: any): number)}
76
/>
77
- <div className={styles.Content}>
77
+ <div className={`${styles.Content} ${styles.ContentMaybeLong}`}>
78
{listItems.length > 0 && (
79
<Fragment>
80
<label className={styles.Label}>Rendered at</label>: {listItems}
@@ -116,7 +116,7 @@ function WhatChanged({
116
117
if (changeDescription.isFirstMount) {
118
return (
119
- <div className={styles.Content}>
119
+ <div className={`${styles.Content} ${styles.ContentShort}`}>
120
<label className={styles.Label}>Why did this render?</label>
121
<div className={styles.WhatChangedItem}>
122
This is the first time the component rendered.
@@ -199,7 +199,7 @@ function WhatChanged({
199
}
200
201
return (
202
- <div className={styles.Content}>
202
+ <div className={`${styles.Content} ${styles.ContentShort}`}>
203
<label className={styles.Label}>Why did this render?</label>
204
{changes}
205
</div>