@samitouri / QOS-React-2 / commits / a5554190c1

fix[compiler playground]: Set source as the pre-change state in HIR diff (#29957)

<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> I have fixed an issue where the display of the HIR diff in the React Compiler Playground was incorrect. The HIR diff is supposed to show the pre-change state as the source, but currently, it is showing EnvironmentConfig as the pre-change state. This PR corrects this by setting the pre-change state to source instead of EnvironmentConfig. ## How did you test this change? <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> before: ![image](https://github.com/facebook/react/assets/37236438/c98aee7a-b569-430e-8698-0f7eff6c21e2) after: ![image](https://github.com/facebook/react/assets/37236438/6113297c-80f9-4e71-a0d1-df8cc87507db)

NISHIZAWA Shuntaro committed Jun 21, 2024 at 01:01 UTC a5554190c1c44aa6ecef0cef46cd109e21b5c0bf
1 file changed +2 -2
compiler/apps/playground/components/Editor/Output.tsx
+2 -2
@@ -104,7 +104,7 @@ async function tabify(source: string, compilerOutput: CompilerOutput) {
104 passName,
105 <TextTabContent
106 output={text}
107 - diff={lastPassOutput ?? null}
107 + diff={passName !== "HIR" ? lastPassOutput : null}
108 showInfoPanel={true}
109 ></TextTabContent>
110 );
@@ -195,7 +195,7 @@ function Output({ store, compilerOutput }: Props) {
195 if (result.kind === "hir" || result.kind === "reactive") {
196 currResult += `function ${result.fnName}\n\n${result.value}`;
197 }
198 - if (currResult !== lastResult) {
198 + if (passName !== "HIR" && currResult !== lastResult) {
199 changedPasses.add(passName);
200 }
201 lastResult = currResult;