Slight tweak to avoid setting an invalid numeric value in props editor
Brian Vaughn committed
Jul 19, 2019 at 09:19 UTC
abe75b0e3909cd037e017a46295302a197d760af
1 file changed
+5
-2
src/devtools/views/Components/EditableValue.js
+5
-2
@@ -59,7 +59,10 @@ export default function EditableValue({
59
60
if (key === 'Enter') {
61
if (dataType === 'number') {
62
- overrideValueFn(path, parseFloat(editableValue));
62
+ const parsedValue = parseFloat(editableValue);
63
+ if (!Number.isNaN(parsedValue)) {
64
+ overrideValueFn(path, parsedValue);
65
+ }
66
} else {
67
overrideValueFn(path, editableValue);
68
}
@@ -72,7 +75,7 @@ export default function EditableValue({
75
setHasPendingChanges(false);
76
}
77
},
75
- [path, editableValue, overrideValueFn, value, dataType]
78
+ [editableValue, dataType, overrideValueFn, path, value]
79
);
80
81
// Render different input types based on the dataType