Add detectable prefix to ReactElement proptype warning.
Jim committed
Jan 27, 2015 at 10:14 UTC
b2f77e6de31c71999a8d294a9bb742643c936b01
4 files changed
+23
-12
src/classic/element/ReactElementValidator.js
+1
-1
@@ -269,7 +269,7 @@ function checkPropTypes(componentName, propTypes, props, location) {
269
loggedTypeFailures[error.message] = true;
270
271
var addendum = getDeclarationErrorAddendum(this);
272
- warning(false, error.message + addendum);
272
+ warning(false, 'Failed propType: ' + error.message + addendum);
273
}
274
}
275
}
src/classic/element/__tests__/ReactElementValidator-test.js
+10
-5
@@ -206,7 +206,8 @@ describe('ReactElementValidator', function() {
206
});
207
ReactTestUtils.renderIntoDocument(React.createElement(ParentComp));
208
expect(console.warn.calls[0].args[0]).toBe(
209
- 'Warning: Invalid prop `color` of type `number` supplied to `MyComp`, ' +
209
+ 'Warning: Failed propType: ' +
210
+ 'Invalid prop `color` of type `number` supplied to `MyComp`, ' +
211
'expected `string`. Check the render method of `ParentComp`.'
212
);
213
});
@@ -247,7 +248,8 @@ describe('ReactElementValidator', function() {
248
249
expect(console.warn.calls.length).toBe(1);
250
expect(console.warn.calls[0].args[0]).toBe(
250
- 'Warning: Required prop `prop` was not specified in `Component`.'
251
+ 'Warning: Failed propType: ' +
252
+ 'Required prop `prop` was not specified in `Component`.'
253
);
254
});
255
@@ -270,7 +272,8 @@ describe('ReactElementValidator', function() {
272
273
expect(console.warn.calls.length).toBe(1);
274
expect(console.warn.calls[0].args[0]).toBe(
273
- 'Warning: Required prop `prop` was not specified in `Component`.'
275
+ 'Warning: Failed propType: ' +
276
+ 'Required prop `prop` was not specified in `Component`.'
277
);
278
});
279
@@ -295,11 +298,13 @@ describe('ReactElementValidator', function() {
298
299
expect(console.warn.calls.length).toBe(2);
300
expect(console.warn.calls[0].args[0]).toBe(
298
- 'Warning: Required prop `prop` was not specified in `Component`.'
301
+ 'Warning: Failed propType: ' +
302
+ 'Required prop `prop` was not specified in `Component`.'
303
);
304
305
expect(console.warn.calls[1].args[0]).toBe(
302
- 'Warning: Invalid prop `prop` of type `number` supplied to ' +
306
+ 'Warning: Failed propType: ' +
307
+ 'Invalid prop `prop` of type `number` supplied to ' +
308
'`Component`, expected `string`.'
309
);
310
src/classic/types/__tests__/ReactPropTypes-test.js
+2
-1
@@ -752,7 +752,8 @@ describe('ReactPropTypes', function() {
752
var instance = <Component num={6} />;
753
instance = ReactTestUtils.renderIntoDocument(instance);
754
expect(console.warn.argsForCall.length).toBe(1);
755
- expect(console.warn.argsForCall[0][0]).toBe('Warning: num must be 5!');
755
+ expect(console.warn.argsForCall[0][0]).toBe(
756
+ 'Warning: Failed propType: num must be 5!');
757
});
758
759
it('should not warn if the validator returned anything else than an error',
src/modern/element/__tests__/ReactJSXElementValidator-test.js
+10
-5
@@ -196,7 +196,8 @@ describe('ReactJSXElementValidator', function() {
196
}
197
ReactTestUtils.renderIntoDocument(<ParentComp />);
198
expect(console.warn.calls[0].args[0]).toBe(
199
- 'Warning: Invalid prop `color` of type `number` supplied to `MyComp`, ' +
199
+ 'Warning: Failed propType: ' +
200
+ 'Invalid prop `color` of type `number` supplied to `MyComp`, ' +
201
'expected `string`. Check the render method of `ParentComp`.'
202
);
203
});
@@ -236,7 +237,8 @@ describe('ReactJSXElementValidator', function() {
237
238
expect(console.warn.calls.length).toBe(1);
239
expect(console.warn.calls[0].args[0]).toBe(
239
- 'Warning: Required prop `prop` was not specified in `Component`.'
240
+ 'Warning: Failed propType: ' +
241
+ 'Required prop `prop` was not specified in `Component`.'
242
);
243
});
244
@@ -255,7 +257,8 @@ describe('ReactJSXElementValidator', function() {
257
258
expect(console.warn.calls.length).toBe(1);
259
expect(console.warn.calls[0].args[0]).toBe(
258
- 'Warning: Required prop `prop` was not specified in `Component`.'
260
+ 'Warning: Failed propType: ' +
261
+ 'Required prop `prop` was not specified in `Component`.'
262
);
263
});
264
@@ -276,11 +279,13 @@ describe('ReactJSXElementValidator', function() {
279
280
expect(console.warn.calls.length).toBe(2);
281
expect(console.warn.calls[0].args[0]).toBe(
279
- 'Warning: Required prop `prop` was not specified in `Component`.'
282
+ 'Warning: Failed propType: ' +
283
+ 'Required prop `prop` was not specified in `Component`.'
284
);
285
286
expect(console.warn.calls[1].args[0]).toBe(
283
- 'Warning: Invalid prop `prop` of type `number` supplied to ' +
287
+ 'Warning: Failed propType: ' +
288
+ 'Invalid prop `prop` of type `number` supplied to ' +
289
'`Component`, expected `string`.'
290
);
291