Land warnOnSubscriptionInsideStartTransition flag (#23353)
We're including this in 18. The feature was already enabled — this just removes the flag.
Andrew Clark committed
Feb 23, 2022 at 18:52 UTC
b3f3da205b9abfc3c70e7018b03114a33ef43ca5
16 files changed
+5
-41
packages/react-reconciler/src/ReactFiberHooks.new.js
+1
-6
@@ -109,7 +109,6 @@ import {
109
entangleTransitions as entangleLegacyQueueTransitions,
110
} from './ReactUpdateQueue.new';
111
import {pushInterleavedQueue} from './ReactFiberInterleavedUpdates.new';
112
-import {warnOnSubscriptionInsideStartTransition} from 'shared/ReactFeatureFlags';
112
import {getTreeId} from './ReactFiberTreeContext.new';
113
114
const {ReactCurrentDispatcher, ReactCurrentBatchConfig} = ReactSharedInternals;
@@ -1992,11 +1991,7 @@ function startTransition(setPending, callback) {
1991
1992
ReactCurrentBatchConfig.transition = prevTransition;
1993
if (__DEV__) {
1995
- if (
1996
- prevTransition === null &&
1997
- warnOnSubscriptionInsideStartTransition &&
1998
- currentTransition._updatedFibers
1999
- ) {
1994
+ if (prevTransition === null && currentTransition._updatedFibers) {
1995
const updatedFibersCount = currentTransition._updatedFibers.size;
1996
if (updatedFibersCount > 10) {
1997
console.warn(
packages/react-reconciler/src/ReactFiberHooks.old.js
+1
-6
@@ -109,7 +109,6 @@ import {
109
entangleTransitions as entangleLegacyQueueTransitions,
110
} from './ReactUpdateQueue.old';
111
import {pushInterleavedQueue} from './ReactFiberInterleavedUpdates.old';
112
-import {warnOnSubscriptionInsideStartTransition} from 'shared/ReactFeatureFlags';
112
import {getTreeId} from './ReactFiberTreeContext.old';
113
114
const {ReactCurrentDispatcher, ReactCurrentBatchConfig} = ReactSharedInternals;
@@ -1992,11 +1991,7 @@ function startTransition(setPending, callback) {
1991
1992
ReactCurrentBatchConfig.transition = prevTransition;
1993
if (__DEV__) {
1995
- if (
1996
- prevTransition === null &&
1997
- warnOnSubscriptionInsideStartTransition &&
1998
- currentTransition._updatedFibers
1999
- ) {
1994
+ if (prevTransition === null && currentTransition._updatedFibers) {
1995
const updatedFibersCount = currentTransition._updatedFibers.size;
1996
if (updatedFibersCount > 10) {
1997
console.warn(
packages/react-reconciler/src/ReactFiberWorkLoop.new.js
+1
-6
@@ -31,7 +31,6 @@ import {
31
disableSchedulerTimeoutInWorkLoop,
32
enableStrictEffects,
33
enableUpdaterTracking,
34
- warnOnSubscriptionInsideStartTransition,
34
enableCache,
35
} from 'shared/ReactFeatureFlags';
36
import ReactSharedInternals from 'shared/ReactSharedInternals';
@@ -397,11 +396,7 @@ export function requestUpdateLane(fiber: Fiber): Lane {
396
397
const isTransition = requestCurrentTransition() !== NoTransition;
398
if (isTransition) {
400
- if (
401
- __DEV__ &&
402
- warnOnSubscriptionInsideStartTransition &&
403
- ReactCurrentBatchConfig.transition !== null
404
- ) {
399
+ if (__DEV__ && ReactCurrentBatchConfig.transition !== null) {
400
const transition = ReactCurrentBatchConfig.transition;
401
if (!transition._updatedFibers) {
402
transition._updatedFibers = new Set();
packages/react-reconciler/src/ReactFiberWorkLoop.old.js
+1
-6
@@ -31,7 +31,6 @@ import {
31
disableSchedulerTimeoutInWorkLoop,
32
enableStrictEffects,
33
enableUpdaterTracking,
34
- warnOnSubscriptionInsideStartTransition,
34
enableCache,
35
} from 'shared/ReactFeatureFlags';
36
import ReactSharedInternals from 'shared/ReactSharedInternals';
@@ -397,11 +396,7 @@ export function requestUpdateLane(fiber: Fiber): Lane {
396
397
const isTransition = requestCurrentTransition() !== NoTransition;
398
if (isTransition) {
400
- if (
401
- __DEV__ &&
402
- warnOnSubscriptionInsideStartTransition &&
403
- ReactCurrentBatchConfig.transition !== null
404
- ) {
399
+ if (__DEV__ && ReactCurrentBatchConfig.transition !== null) {
400
const transition = ReactCurrentBatchConfig.transition;
401
if (!transition._updatedFibers) {
402
transition._updatedFibers = new Set();
packages/react/src/ReactStartTransition.js
+1
-6
@@ -8,7 +8,6 @@
8
*/
9
10
import ReactCurrentBatchConfig from './ReactCurrentBatchConfig';
11
-import {warnOnSubscriptionInsideStartTransition} from 'shared/ReactFeatureFlags';
11
12
export function startTransition(scope: () => void) {
13
const prevTransition = ReactCurrentBatchConfig.transition;
@@ -24,11 +23,7 @@ export function startTransition(scope: () => void) {
23
ReactCurrentBatchConfig.transition = prevTransition;
24
25
if (__DEV__) {
27
- if (
28
- prevTransition === null &&
29
- warnOnSubscriptionInsideStartTransition &&
30
- currentTransition._updatedFibers
31
- ) {
26
+ if (prevTransition === null && currentTransition._updatedFibers) {
27
const updatedFibersCount = currentTransition._updatedFibers.size;
28
if (updatedFibersCount > 10) {
29
console.warn(
packages/react/src/__tests__/ReactStartTransition-test.js
-1
@@ -27,7 +27,6 @@ describe('ReactStartTransition', () => {
27
useTransition = React.useTransition;
28
});
29
30
- // @gate warnOnSubscriptionInsideStartTransition || !__DEV__
30
it('Warns if a suspicious number of fibers are updated inside startTransition', () => {
31
const subs = new Set();
32
const useUserSpaceSubscription = () => {
packages/shared/ReactFeatureFlags.js
-1
@@ -13,7 +13,6 @@
13
// Flags that can likely be deleted or landed without consequences
14
// -----------------------------------------------------------------------------
15
16
-export const warnOnSubscriptionInsideStartTransition = false;
16
export const enableSuspenseServerRenderer = true;
17
export const enableSelectiveHydration = true;
18
export const warnAboutDeprecatedLifecycles = true;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -49,7 +49,6 @@ export const disableTextareaChildren = false;
49
export const disableModulePatternComponents = false;
50
export const warnUnstableRenderSubtreeIntoContainer = false;
51
export const warnAboutSpreadingKeyToJSX = false;
52
-export const warnOnSubscriptionInsideStartTransition = false;
52
export const enableSuspenseAvoidThisFallback = false;
53
export const enableSuspenseAvoidThisFallbackFizz = false;
54
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -40,7 +40,6 @@ export const disableTextareaChildren = false;
40
export const disableModulePatternComponents = false;
41
export const warnUnstableRenderSubtreeIntoContainer = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -40,7 +40,6 @@ export const disableTextareaChildren = false;
40
export const disableModulePatternComponents = false;
41
export const warnUnstableRenderSubtreeIntoContainer = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
-1
@@ -49,7 +49,6 @@ export const enableSuspenseLayoutEffectSemantics = false;
49
export const enableGetInspectorDataForInstanceInProduction = false;
50
export const enableNewReconciler = false;
51
export const deferRenderPhaseUpdateToNextBatch = false;
52
-export const warnOnSubscriptionInsideStartTransition = false;
52
export const enableSuspenseAvoidThisFallback = false;
53
export const enableSuspenseAvoidThisFallbackFizz = false;
54
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -40,7 +40,6 @@ export const disableTextareaChildren = false;
40
export const disableModulePatternComponents = true;
41
export const warnUnstableRenderSubtreeIntoContainer = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = true;
44
export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.testing.js
-1
@@ -40,7 +40,6 @@ export const disableTextareaChildren = false;
40
export const disableModulePatternComponents = false;
41
export const warnUnstableRenderSubtreeIntoContainer = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = false;
44
export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.testing.www.js
-1
@@ -40,7 +40,6 @@ export const disableTextareaChildren = __EXPERIMENTAL__;
40
export const disableModulePatternComponents = true;
41
export const warnUnstableRenderSubtreeIntoContainer = false;
42
export const warnAboutSpreadingKeyToJSX = false;
43
-export const warnOnSubscriptionInsideStartTransition = false;
43
export const enableSuspenseAvoidThisFallback = true;
44
export const enableSuspenseAvoidThisFallbackFizz = false;
45
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -24,7 +24,6 @@ export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
24
export const enableLazyContextPropagation = __VARIANT__;
25
export const enableSyncDefaultUpdates = __VARIANT__;
26
export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
27
-export const warnOnSubscriptionInsideStartTransition = __VARIANT__;
27
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = __VARIANT__;
28
export const enableClientRenderFallbackOnHydrationMismatch = __VARIANT__;
29
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -30,7 +30,6 @@ export const {
30
disableSchedulerTimeoutInWorkLoop,
31
enableLazyContextPropagation,
32
enableSyncDefaultUpdates,
33
- warnOnSubscriptionInsideStartTransition,
33
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
34
enableClientRenderFallbackOnHydrationMismatch,
35
} = dynamicFeatureFlags;