Remove unused flag (#18132)
Dan Abramov committed
Feb 27, 2020 at 12:58 UTC
b4e314891826da7e65ce600cdcf320041dafc0d2
10 files changed
+1
-23
packages/react-reconciler/src/ReactFiberWorkLoop.js
+1
-12
@@ -28,7 +28,6 @@ import {
28
warnAboutUnmockedScheduler,
29
flushSuspenseFallbacksInTests,
30
disableSchedulerTimeoutBasedOnReactExpirationTime,
31
- enableTrainModelFix,
31
} from 'shared/ReactFeatureFlags';
32
import ReactSharedInternals from 'shared/ReactSharedInternals';
33
import invariant from 'shared/invariant';
@@ -548,11 +547,7 @@ function getNextRootExpirationTimeToWorkOn(root: FiberRoot): ExpirationTime {
547
lastPingedTime > nextKnownPendingLevel
548
? lastPingedTime
549
: nextKnownPendingLevel;
551
- if (
552
- enableTrainModelFix &&
553
- nextLevel <= Idle &&
554
- firstPendingTime !== nextLevel
555
- ) {
550
+ if (nextLevel <= Idle && firstPendingTime !== nextLevel) {
551
// Don't work on Idle/Never priority unless everything else is committed.
552
return NoWork;
553
}
@@ -2478,12 +2473,6 @@ export function pingSuspendedRoot(
2473
// Mark the time at which this ping was scheduled.
2474
root.lastPingedTime = suspendedTime;
2475
2481
- if (!enableTrainModelFix && root.finishedExpirationTime === suspendedTime) {
2482
- // If there's a pending fallback waiting to commit, throw it away.
2483
- root.finishedExpirationTime = NoWork;
2484
- root.finishedWork = null;
2485
- }
2486
-
2476
ensureRootIsScheduled(root);
2477
schedulePendingInteractions(root, suspendedTime);
2478
}
packages/shared/ReactFeatureFlags.js
-2
@@ -81,8 +81,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
81
82
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
83
84
-export const enableTrainModelFix = true;
85
-
84
export const enableTrustedTypesIntegration = false;
85
86
// Flag to turn event.target and event.currentTarget in ReactNative from a reactTag to a component instance
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -41,7 +41,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
41
export const warnAboutStringRefs = false;
42
export const disableLegacyContext = false;
43
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
44
-export const enableTrainModelFix = true;
44
export const enableTrustedTypesIntegration = false;
45
export const disableTextareaChildren = false;
46
export const disableMapsAsChildren = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = false;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.persistent.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = false;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = false;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = false;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.testing.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = false;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = false;
packages/shared/forks/ReactFeatureFlags.testing.www.js
-1
@@ -35,7 +35,6 @@ export const warnAboutDefaultPropsOnFunctionComponents = false;
35
export const warnAboutStringRefs = false;
36
export const disableLegacyContext = __EXPERIMENTAL__;
37
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
38
-export const enableTrainModelFix = true;
38
export const enableTrustedTypesIntegration = false;
39
export const enableNativeTargetAsInstance = false;
40
export const disableTextareaChildren = __EXPERIMENTAL__;
packages/shared/forks/ReactFeatureFlags.www.js
-2
@@ -43,8 +43,6 @@ export const disableLegacyContext = __EXPERIMENTAL__;
43
export const warnAboutStringRefs = false;
44
export const warnAboutDefaultPropsOnFunctionComponents = false;
45
46
-export const enableTrainModelFix = true;
47
-
46
export const enableSuspenseServerRenderer = true;
47
export const enableSelectiveHydration = true;
48