Use value on <select> instead of setting selected on <option> (#11206)
Clark Du committed
Oct 16, 2017 at 18:46 UTC
b623bf43a098fece9beb7a49f1a113e15735fbd9
1 file changed
+8
-18
fixtures/attribute-behavior/src/App.js
+8
-18
@@ -958,35 +958,25 @@ class App extends React.Component {
958
return (
959
<div>
960
<div>
961
- <select onChange={this.onUpdateSort}>
962
- <option
963
- selected={this.state.sortOrder === ALPHABETICAL}
964
- value={ALPHABETICAL}>
961
+ <select value={this.state.sortOrder} onChange={this.onUpdateSort}>
962
+ <option value={ALPHABETICAL}>
963
alphabetical
964
</option>
967
- <option
968
- selected={this.state.sortOrder === REV_ALPHABETICAL}
969
- value={REV_ALPHABETICAL}>
965
+ <option value={REV_ALPHABETICAL}>
966
reverse alphabetical
967
</option>
972
- <option
973
- selected={this.state.sortOrder === GROUPED_BY_ROW_PATTERN}
974
- value={GROUPED_BY_ROW_PATTERN}>
968
+ <option value={GROUPED_BY_ROW_PATTERN}>
969
grouped by row pattern :)
970
</option>
971
</select>
978
- <select onChange={this.onUpdateFilter}>
979
- <option selected={this.state.sortOrder === ALL} value={ALL}>
972
+ <select value={this.state.filter} onChange={this.onUpdateFilter}>
973
+ <option value={ALL}>
974
all
975
</option>
982
- <option
983
- selected={this.state.sortOrder === INCOMPLETE}
984
- value={INCOMPLETE}>
976
+ <option value={INCOMPLETE}>
977
incomplete
978
</option>
987
- <option
988
- selected={this.state.sortOrder === COMPLETE}
989
- value={COMPLETE}>
979
+ <option value={COMPLETE}>
980
complete
981
</option>
982
</select>