@samitouri / QOS-React-2 / commits / b93b4f0745

Should not throw for children of iframe or object (#26458)

Still needs a regression test to test this for the future.

Sebastian Markbåge committed Mar 22, 2023 at 08:56 UTC b93b4f07454298e99012201a5ecdd195a41baa50
1 file changed +3 -2
packages/react-dom-bindings/src/client/ReactDOMComponent.js
+3 -2
@@ -595,8 +595,6 @@ export function setInitialProperties(
595 listenToNonDelegatedEvent('close', domElement);
596 props = rawProps;
597 break;
598 - case 'iframe':
599 - case 'object':
598 case 'embed':
599 if (
600 rawProps.children != null ||
@@ -608,6 +606,9 @@ export function setInitialProperties(
606 'use `dangerouslySetInnerHTML`.',
607 );
608 }
609 + // eslint-disable-next-line no-fallthrough
610 + case 'iframe':
611 + case 'object':
612 // We listen to this event in case to ensure emulated bubble
613 // listeners still fire for the load event.
614 listenToNonDelegatedEvent('load', domElement);