@samitouri / QOS-React-2 / commits / bfaeb4a461

Fix incorrect use of NoLanes in executionContext check (#33170)

## Summary This PR fixes a likely incorrect condition in the `scheduleUpdateOnFiber` function inside `ReactFiberWorkLoop.js`. Previously, the code checked: ```js (executionContext & RenderContext) !== NoLanes ```` However, `NoLanes` is part of the lane priority system, not the execution context flags. The intent here seems to be to detect whether the current execution context includes `RenderContext`, which should be compared against `NoContext`, not `NoLanes`. This fix replaces `NoLanes` with `NoContext` for semantic correctness and consistency with other checks throughout the codebase. **Fixes [[#33169](https://github.com/facebook/react/issues/33169)](https://github.com/facebook/react/issues/33169)** --- ## How did you test this change? I ran the following commands to validate correctness and ensure nothing was broken: * `yarn lint` * `yarn linc` * `yarn test` * `yarn test --prod` * `yarn flow` * `yarn prettier` All checks passed. Since this is a minor internal logic fix and doesn't change public behavior or APIs, no additional tests are necessary at this time.

0xFango committed May 23, 2025 at 09:02 UTC bfaeb4a46175fa0f4edf2eba58349d5029e5e86e
1 file changed +1 -1
packages/react-reconciler/src/ReactFiberWorkLoop.js
+1 -1
@@ -908,7 +908,7 @@ export function scheduleUpdateOnFiber(
908 markRootUpdated(root, lane);
909
910 if (
911 - (executionContext & RenderContext) !== NoLanes &&
911 + (executionContext & RenderContext) !== NoContext &&
912 root === workInProgressRoot
913 ) {
914 // This update was dispatched during the render phase. This is a mistake