@samitouri / QOS-React-2 / commits / c47f3cfa17

Restore experimental build script's ability to auto download latest build (#20717)

Brian Vaughn committed Feb 2, 2021 at 16:40 UTC c47f3cfa1743ffb3b9c7f94ef94731e89a9d261a
2 files changed +8 -7
scripts/release/download-experimental-build.js
+5 -4
@@ -18,15 +18,16 @@ const printSummary = require('./download-experimental-build-commands/print-summa
18 const run = async () => {
19 try {
20 addDefaultParamValue('-r', '--releaseChannel', 'experimental');
21 + addDefaultParamValue(
22 + null,
23 + '--build',
24 + await getLatestMasterBuildNumber(true)
25 + );
26
27 const params = await parseParams();
28 params.cwd = join(__dirname, '..', '..');
29 params.packages = await getPublicPackages(true);
30
26 - if (!params.build) {
27 - params.build = await getLatestMasterBuildNumber(true);
28 - }
29 -
31 await checkEnvironmentVariables(params);
32 await downloadBuildArtifacts(params);
33
scripts/release/utils.js
+3 -3
@@ -17,18 +17,18 @@ const logger = createLogger({
17 storagePath: join(__dirname, '.progress-estimator'),
18 });
19
20 -const addDefaultParamValue = (shortName, longName, defaultValue) => {
20 +const addDefaultParamValue = (optionalShortName, longName, defaultValue) => {
21 let found = false;
22 for (let i = 0; i < process.argv.length; i++) {
23 const current = process.argv[i];
24 - if (current === shortName || current.startsWith(`${longName}=`)) {
24 + if (current === optionalShortName || current.startsWith(`${longName}=`)) {
25 found = true;
26 break;
27 }
28 }
29
30 if (!found) {
31 - process.argv.push(shortName, defaultValue);
31 + process.argv.push(`${longName}=${defaultValue}`);
32 }
33 };
34