Add prettier instructions to PR template and contribution guide
Andrew Clark committed
Mar 15, 2017 at 17:12 UTC
c71a8ecd00e73e5950c994e9e0e8422edb7889ef
2 files changed
+8
-6
.github/PULL_REQUEST_TEMPLATE.md
+4
-3
@@ -5,6 +5,7 @@
5
3. If you've changed APIs, update the documentation.
6
4. Ensure the test suite passes (`npm test`).
7
5. Make sure your code lints (`npm run lint`).
8
-6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
9
-7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
10
-8. If you haven't already, complete the [CLA](https://code.facebook.com/cla).
8
+6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
9
+7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
10
+8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
11
+9. If you haven't already, complete the CLA.
docs/contributing/how-to-contribute.md
+4
-3
@@ -81,9 +81,10 @@ The core team is monitoring for pull requests. We will review your pull request
81
3. If you've changed APIs, update the documentation.
82
4. Ensure the test suite passes (`npm test`).
83
5. Make sure your code lints (`npm run lint`).
84
-6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
85
-7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
86
-8. If you haven't already, complete the CLA.
84
+6. Format your code with [prettier](https://github.com/prettier/prettier) (`npm run prettier`).
85
+7. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
86
+8. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
87
+9. If you haven't already, complete the CLA.
88
89
### Contributor License Agreement (CLA)
90