Revert "Fix email cursor jump (#18379)" (#18459)
* Revert "Fix email cursor jump (#18379)" This reverts commit 9b88b78b3d61e8fe81968d59b74592d5a53540b7. * Leave fixtures be
Dan Abramov committed
Apr 1, 2020 at 22:44 UTC
c80cd8ee27d24bb5b9a6136ede6875d13b9f1ba4
2 files changed
+4
-8
packages/react-dom/src/client/ReactDOMInput.js
+2
-2
@@ -410,8 +410,8 @@ export function setDefaultValue(
410
value: *,
411
) {
412
if (
413
- // Focused number and email inputs synchronize on blur. See ChangeEventPlugin.js
414
- (type !== 'number' && type !== 'email') ||
413
+ // Focused number inputs synchronize on blur. See ChangeEventPlugin.js
414
+ type !== 'number' ||
415
node.ownerDocument.activeElement !== node
416
) {
417
if (value == null) {
packages/react-dom/src/events/ChangeEventPlugin.js
+2
-6
@@ -236,17 +236,13 @@ function getTargetInstForInputOrChangeEvent(topLevelType, targetInst) {
236
function handleControlledInputBlur(node) {
237
const state = node._wrapperState;
238
239
- if (
240
- !state ||
241
- !state.controlled ||
242
- (node.type !== 'number' && node.type !== 'email')
243
- ) {
239
+ if (!state || !state.controlled || node.type !== 'number') {
240
return;
241
}
242
243
if (!disableInputAttributeSyncing) {
244
// If controlled, assign the value attribute to the current value on blur
249
- setDefaultValue(node, node.type, node.value);
245
+ setDefaultValue(node, 'number', node.value);
246
}
247
}
248