Use this.getDOMNode() instead of last argument of componentDidUpdate
Context is adding another argument that shifts all of them by one. Since we can already use this.getDOMNode(), it doesn't really make sense to pass it as an argument to that function.
Christopher Chedeau committed
Nov 20, 2013 at 14:02 UTC
c8b6fe51d95805f78744a48f12a40d5556a4f162
3 files changed
+5
-3
src/addons/transitions/ReactTransitionableChild.js
+1
-1
@@ -138,7 +138,7 @@ var ReactTransitionableChild = React.createClass({
138
}
139
},
140
141
- componentDidUpdate: function(prevProps, prevState, prevContext, node) {
141
+ componentDidUpdate: function(prevProps, prevState, prevContext) {
142
if (prevProps.children && !this.props.children) {
143
this.transition('leave', true, this.props.onDoneLeaving);
144
}
src/dom/components/ReactDOMInput.js
+2
-1
@@ -92,7 +92,8 @@ var ReactDOMInput = ReactCompositeComponent.createClass({
92
delete instancesByReactID[id];
93
},
94
95
- componentDidUpdate: function(prevProps, prevState, prevContext, rootNode) {
95
+ componentDidUpdate: function(prevProps, prevState, prevContext) {
96
+ var rootNode = this.getDOMNode();
97
if (this.props.checked != null) {
98
DOMPropertyOperations.setValueForProperty(
99
rootNode,
src/dom/components/ReactDOMTextarea.js
+2
-1
@@ -110,9 +110,10 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({
110
return textarea(props, this.state.initialValue);
111
},
112
113
- componentDidUpdate: function(prevProps, prevState, prevContext, rootNode) {
113
+ componentDidUpdate: function(prevProps, prevState, prevContext) {
114
var value = this.getValue();
115
if (value != null) {
116
+ var rootNode = this.getDOMNode();
117
// Cast `value` to a string to ensure the value is set correctly. While
118
// browsers typically do this as necessary, jsdom doesn't.
119
DOMPropertyOperations.setValueForProperty(rootNode, 'value', '' + value);