Flow: add some missing types in react-reconciler (#25316)
To enable the next Flow version, we need to annotate exported values. This adds a few automatically inferred types that didn't look huge or just `any`.
Jan Kassens committed
Sep 23, 2022 at 10:28 UTC
cc8cb145f0bfebaeaddc4e7439efe5f3e14639ae
4 files changed
+14
-14
packages/react-reconciler/src/ReactFiber.new.js
+6
-6
@@ -693,7 +693,7 @@ export function createFiberFromSuspense(
693
mode: TypeOfMode,
694
lanes: Lanes,
695
key: null | string,
696
-) {
696
+): Fiber {
697
const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
698
fiber.elementType = REACT_SUSPENSE_TYPE;
699
fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
705
mode: TypeOfMode,
706
lanes: Lanes,
707
key: null | string,
708
-) {
708
+): Fiber {
709
const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
710
fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
711
fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
717
mode: TypeOfMode,
718
lanes: Lanes,
719
key: null | string,
720
-) {
720
+): Fiber {
721
const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
722
fiber.elementType = REACT_OFFSCREEN_TYPE;
723
fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
736
mode: TypeOfMode,
737
lanes: Lanes,
738
key: null | string,
739
-) {
739
+): Fiber {
740
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
741
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
742
fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
757
mode: TypeOfMode,
758
lanes: Lanes,
759
key: null | string,
760
-) {
760
+): Fiber {
761
const fiber = createFiber(CacheComponent, pendingProps, key, mode);
762
fiber.elementType = REACT_CACHE_TYPE;
763
fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
769
mode: TypeOfMode,
770
lanes: Lanes,
771
key: null | string,
772
-) {
772
+): Fiber {
773
const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
774
fiber.elementType = REACT_TRACING_MARKER_TYPE;
775
fiber.lanes = lanes;
packages/react-reconciler/src/ReactFiber.old.js
+6
-6
@@ -693,7 +693,7 @@ export function createFiberFromSuspense(
693
mode: TypeOfMode,
694
lanes: Lanes,
695
key: null | string,
696
-) {
696
+): Fiber {
697
const fiber = createFiber(SuspenseComponent, pendingProps, key, mode);
698
fiber.elementType = REACT_SUSPENSE_TYPE;
699
fiber.lanes = lanes;
@@ -705,7 +705,7 @@ export function createFiberFromSuspenseList(
705
mode: TypeOfMode,
706
lanes: Lanes,
707
key: null | string,
708
-) {
708
+): Fiber {
709
const fiber = createFiber(SuspenseListComponent, pendingProps, key, mode);
710
fiber.elementType = REACT_SUSPENSE_LIST_TYPE;
711
fiber.lanes = lanes;
@@ -717,7 +717,7 @@ export function createFiberFromOffscreen(
717
mode: TypeOfMode,
718
lanes: Lanes,
719
key: null | string,
720
-) {
720
+): Fiber {
721
const fiber = createFiber(OffscreenComponent, pendingProps, key, mode);
722
fiber.elementType = REACT_OFFSCREEN_TYPE;
723
fiber.lanes = lanes;
@@ -736,7 +736,7 @@ export function createFiberFromLegacyHidden(
736
mode: TypeOfMode,
737
lanes: Lanes,
738
key: null | string,
739
-) {
739
+): Fiber {
740
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
741
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
742
fiber.lanes = lanes;
@@ -757,7 +757,7 @@ export function createFiberFromCache(
757
mode: TypeOfMode,
758
lanes: Lanes,
759
key: null | string,
760
-) {
760
+): Fiber {
761
const fiber = createFiber(CacheComponent, pendingProps, key, mode);
762
fiber.elementType = REACT_CACHE_TYPE;
763
fiber.lanes = lanes;
@@ -769,7 +769,7 @@ export function createFiberFromTracingMarker(
769
mode: TypeOfMode,
770
lanes: Lanes,
771
key: null | string,
772
-) {
772
+): Fiber {
773
const fiber = createFiber(TracingMarkerComponent, pendingProps, key, mode);
774
fiber.elementType = REACT_TRACING_MARKER_TYPE;
775
fiber.lanes = lanes;
packages/react-reconciler/src/ReactFiberAct.new.js
+1
-1
@@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
37
return false;
38
}
39
40
-export function isConcurrentActEnvironment() {
40
+export function isConcurrentActEnvironment(): void | boolean {
41
if (__DEV__) {
42
const isReactActEnvironmentGlobal =
43
// $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global
packages/react-reconciler/src/ReactFiberAct.old.js
+1
-1
@@ -37,7 +37,7 @@ export function isLegacyActEnvironment(fiber: Fiber): boolean {
37
return false;
38
}
39
40
-export function isConcurrentActEnvironment() {
40
+export function isConcurrentActEnvironment(): void | boolean {
41
if (__DEV__) {
42
const isReactActEnvironmentGlobal =
43
// $FlowFixMe – Flow doesn't know about IS_REACT_ACT_ENVIRONMENT global