Tweaked overflow check
Brian Vaughn committed
Jun 18, 2019 at 08:59 UTC
cf19916be7d3e89ddda4b65d85f82ec37b7351e9
2 files changed
+12
-15
src/devtools/views/Profiler/SidebarSelectedFiberInfo.css
+3
-6
@@ -10,14 +10,11 @@
10
.Content {
11
padding: 0.5rem;
12
user-select: none;
13
+ overflow-y: auto;
14
}
15
15
-.ContentShort {
16
- overflow-y: visible;
17
-}
18
-
19
-.ContentMaybeLong {
20
- overflow-y: auto;
16
+.WhatChanged {
17
+ margin-bottom: 1rem;
18
}
19
20
.Component {
src/devtools/views/Profiler/SidebarSelectedFiberInfo.js
+9
-9
@@ -68,13 +68,13 @@ export default function SidebarSelectedFiberInfo(_: Props) {
68
<ButtonIcon type="close" />
69
</Button>
70
</div>
71
- <WhatChanged
72
- commitIndex={((selectedCommitIndex: any): number)}
73
- fiberID={((selectedFiberID: any): number)}
74
- profilerStore={profilerStore}
75
- rootID={((rootID: any): number)}
76
- />
77
- <div className={`${styles.Content} ${styles.ContentMaybeLong}`}>
71
+ <div className={styles.Content}>
72
+ <WhatChanged
73
+ commitIndex={((selectedCommitIndex: any): number)}
74
+ fiberID={((selectedFiberID: any): number)}
75
+ profilerStore={profilerStore}
76
+ rootID={((rootID: any): number)}
77
+ />
78
{listItems.length > 0 && (
79
<Fragment>
80
<label className={styles.Label}>Rendered at</label>: {listItems}
@@ -116,7 +116,7 @@ function WhatChanged({
116
117
if (changeDescription.isFirstMount) {
118
return (
119
- <div className={`${styles.Content} ${styles.ContentShort}`}>
119
+ <div className={styles.WhatChanged}>
120
<label className={styles.Label}>Why did this render?</label>
121
<div className={styles.WhatChangedItem}>
122
This is the first time the component rendered.
@@ -199,7 +199,7 @@ function WhatChanged({
199
}
200
201
return (
202
- <div className={`${styles.Content} ${styles.ContentShort}`}>
202
+ <div className={styles.WhatChanged}>
203
<label className={styles.Label}>Why did this render?</label>
204
{changes}
205
</div>