[string-refs] remove enableLogStringRefsProd flag (#31414)
We no longer need this production logging.
Jan Kassens committed
Nov 6, 2024 at 09:00 UTC
d1f04722d617600cc6cd96dcebc1c2ef7affc904
8 files changed
+2
-20
packages/react/src/jsx/ReactJSXElement.js
+2
-6
@@ -23,7 +23,6 @@ import {
23
disableStringRefs,
24
disableDefaultPropsExceptForClasses,
25
enableOwnerStacks,
26
- enableLogStringRefsProd,
26
} from 'shared/ReactFeatureFlags';
27
import {checkPropStringCoercion} from 'shared/CheckStringCoercion';
28
import {ClassComponent} from 'react-reconciler/src/ReactWorkTags';
@@ -75,7 +74,7 @@ let didWarnAboutStringRefs;
74
let didWarnAboutElementRef;
75
let didWarnAboutOldJSXRuntime;
76
78
-if (__DEV__ || enableLogStringRefsProd) {
77
+if (__DEV__) {
78
didWarnAboutStringRefs = {};
79
didWarnAboutElementRef = {};
80
}
@@ -1228,16 +1227,13 @@ function stringRefAsCallbackRef(stringRef, type, owner, value) {
1227
);
1228
}
1229
1231
- if (__DEV__ || enableLogStringRefsProd) {
1230
+ if (__DEV__) {
1231
if (
1232
// Will already warn with "Function components cannot be given refs"
1233
!(typeof type === 'function' && !isReactClass(type))
1234
) {
1235
const componentName = getComponentNameFromFiber(owner) || 'Component';
1236
if (!didWarnAboutStringRefs[componentName]) {
1238
- if (enableLogStringRefsProd) {
1239
- enableLogStringRefsProd(componentName, stringRef);
1240
- }
1237
if (__DEV__) {
1238
console.error(
1239
'Component "%s" contains the string ref "%s". Support for string refs ' +
packages/shared/ReactFeatureFlags.js
-8
@@ -210,14 +210,6 @@ export const disableClientCache = true;
210
211
export const disableStringRefs = true;
212
213
-/**
214
- * If set to a function, the function will be called with the component name
215
- * and ref string.
216
- *
217
- * NOTE: This happens also in the production build.
218
- */
219
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
220
-
213
// Warn on any usage of ReactTestRenderer
214
export const enableReactTestRendererWarning = true;
215
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -65,7 +65,6 @@ export const enableLazyContextPropagation = true;
65
export const enableLegacyCache = false;
66
export const enableLegacyFBSupport = false;
67
export const enableLegacyHidden = false;
68
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
68
export const enableNoCloningMemoCache = false;
69
export const enableOwnerStacks = false;
70
export const enablePostpone = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -56,7 +56,6 @@ export const enableContextProfiling = false;
56
export const enableLegacyCache = false;
57
export const enableLegacyFBSupport = false;
58
export const enableLegacyHidden = false;
59
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
59
export const enableNoCloningMemoCache = false;
60
export const enableObjectFiber = false;
61
export const enableOwnerStacks = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -44,7 +44,6 @@ export const enableUseEffectEventHook = false;
44
export const favorSafetyOverHydrationPerf = true;
45
export const enableComponentStackLocations = true;
46
export const enableLegacyFBSupport = false;
47
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
47
export const enableFilterEmptyStringAttributesDOM = true;
48
export const enableGetInspectorDataForInstanceInProduction = false;
49
export const enableFabricCompleteRootInCommitPhase = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -46,7 +46,6 @@ export const enableUseEffectEventHook = false;
46
export const favorSafetyOverHydrationPerf = true;
47
export const enableComponentStackLocations = true;
48
export const enableLegacyFBSupport = false;
49
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
49
export const enableFilterEmptyStringAttributesDOM = true;
50
export const enableGetInspectorDataForInstanceInProduction = false;
51
export const enableRenderableContext = false;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -22,7 +22,6 @@ export const disableStringRefs = __VARIANT__;
22
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
23
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
24
export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
25
-export const enableLogStringRefsProd: null | ((string, string) => void) = null;
25
export const enableNoCloningMemoCache = __VARIANT__;
26
export const enableObjectFiber = __VARIANT__;
27
export const enableRenderableContext = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -25,7 +25,6 @@ export const {
25
enableDO_NOT_USE_disableStrictPassiveEffect,
26
enableHiddenSubtreeInsertionEffectCleanup,
27
enableInfiniteRenderLoopDetection,
28
- enableLogStringRefsProd,
28
enableNoCloningMemoCache,
29
enableObjectFiber,
30
enableRenderableContext,