Clear more Fiber fields in detachFiber (#18556)
Dominic Gannaway committed
Apr 9, 2020 at 18:31 UTC
d48dbb824985166ecb7b2959db03090a8593dce0
2 files changed
+8
packages/react-reconciler/src/ReactFiberCommitWork.new.js
+4
@@ -1118,6 +1118,7 @@ function detachFiber(fiber: Fiber) {
1118
// itself will be GC:ed when the parent updates the next time.
1119
fiber.return = null;
1120
fiber.child = null;
1121
+ fiber.sibling = null;
1122
fiber.memoizedState = null;
1123
fiber.updateQueue = null;
1124
fiber.dependencies = null;
@@ -1127,6 +1128,9 @@ function detachFiber(fiber: Fiber) {
1128
fiber.pendingProps = null;
1129
fiber.memoizedProps = null;
1130
fiber.stateNode = null;
1131
+ if (__DEV__) {
1132
+ fiber._debugOwner = null;
1133
+ }
1134
}
1135
1136
function emptyPortalContainer(current: Fiber) {
packages/react-reconciler/src/ReactFiberCommitWork.old.js
+4
@@ -1118,6 +1118,7 @@ function detachFiber(fiber: Fiber) {
1118
// itself will be GC:ed when the parent updates the next time.
1119
fiber.return = null;
1120
fiber.child = null;
1121
+ fiber.sibling = null;
1122
fiber.memoizedState = null;
1123
fiber.updateQueue = null;
1124
fiber.dependencies = null;
@@ -1127,6 +1128,9 @@ function detachFiber(fiber: Fiber) {
1128
fiber.pendingProps = null;
1129
fiber.memoizedProps = null;
1130
fiber.stateNode = null;
1131
+ if (__DEV__) {
1132
+ fiber._debugOwner = null;
1133
+ }
1134
}
1135
1136
function emptyPortalContainer(current: Fiber) {