@samitouri / QOS-React-2 / commits / db9e5c9715

Updated all GitHub links to point to React repo

Brian Vaughn committed Aug 15, 2019 at 11:17 UTC db9e5c971507e40bdaa41468dde490949c84611f
11 files changed +20 -15
CHANGELOG.md
+2 -2
@@ -17,7 +17,7 @@
17 #### Improved performance
18 The legacy DevTools extension used to add significant performance overhead, making it unusable for some larger React applications. That overhead has been effectively eliminated in version 4.
19
20 -[Learn more](https://github.com/bvaughn/react-devtools-experimental/blob/master/OVERVIEW.md) about the performance optimizations that made this possible.
20 +[Learn more](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md) about the performance optimizations that made this possible.
21
22 #### Component stacks
23
@@ -43,7 +43,7 @@ Filter preferences are remembered between sessions.
43
44 #### No more in-line props
45
46 -Components in the tree no longer show in-line props. This was done to [make DevTools faster](https://github.com/bvaughn/react-devtools-experimental/blob/master/OVERVIEW.md) and to make it easier to browse larger component trees.
46 +Components in the tree no longer show in-line props. This was done to [make DevTools faster](https://github.com/facebook/react/blob/master/packages/react-devtools/OVERVIEW.md) and to make it easier to browse larger component trees.
47
48 You can view a component's props, state, and hooks by selecting it:
49
OVERVIEW.md
+1 -1
@@ -229,7 +229,7 @@ Even when dealing with a single component, serializing deeply nested properties
229
230 Hooks present a unique challenge for the DevTools because of the concept of _custom_ hooks. (A custom hook is essentially any function that calls at least one of the built-in hooks. By convention custom hooks also have names that begin with "use".)
231
232 -So how does DevTools identify custom functions called from within third party components? It does this by temporarily overriding React's built-in hooks and shallow rendering the component in question. Whenever one of the (overridden) built-in hooks are called, it parses the call stack to spot potential custom hooks (functions between the component itself and the built-in hook). This approach enables it to build a tree structure describing all of the calls to both the built-in _and_ custom hooks, along with the values passed to those hooks. (If you're interested in learning more about this, [here is the source code](https://github.com/bvaughn/react-devtools-experimental/blob/master/src/backend/ReactDebugHooks.js).)
232 +So how does DevTools identify custom functions called from within third party components? It does this by temporarily overriding React's built-in hooks and shallow rendering the component in question. Whenever one of the (overridden) built-in hooks are called, it parses the call stack to spot potential custom hooks (functions between the component itself and the built-in hook). This approach enables it to build a tree structure describing all of the calls to both the built-in _and_ custom hooks, along with the values passed to those hooks. (If you're interested in learning more about this, [here is the source code](https://github.com/facebook/react/blob/master/packages/react-debug-tools/src/ReactDebugHooks.js).)
233
234 > **Note**: DevTools obtains hooks info by re-rendering a component.
235 > Breakpoints will be invoked during this additional (shallow) render,
README.md
+1 -1
@@ -20,4 +20,4 @@ yarn build:extension:firefox # builds at "shells/browser/firefox/build"
20
21 # Support
22
23 -As this extension is in a beta period, it is not officially supported. However if you find a bug, we'd appreciate you reporting it as a [GitHub issue](https://github.com/bvaughn/react-devtools-experimental/issues/new) with repro instructions.
\ No newline at end of file
23 +As this extension is in a beta period, it is not officially supported. However if you find a bug, we'd appreciate you reporting it as a [GitHub issue](https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools) with repro instructions.
\ No newline at end of file
package.json
+1 -1
@@ -46,7 +46,7 @@
46 "build:extension:firefox:dev": "cross-env NODE_ENV=development node ./shells/browser/firefox/build",
47 "build:standalone": "cd packages/react-devtools-core && yarn run build",
48 "deploy": "yarn run deploy:demo && yarn run deploy:chrome && yarn run deploy:firefox",
49 - "deploy:demo": "yarn run build:demo && cd shells/dev/ && now deploy && now alias react-devtools-experimental",
49 + "deploy:demo": "yarn run build:inline && yarn run build:demo && cd shells/dev/ && now deploy && now alias react-devtools-experimental",
50 "deploy:chrome": "node ./shells/browser/chrome/deploy",
51 "deploy:firefox": "node ./shells/browser/firefox/deploy",
52 "linc": "lint-staged",
packages/react-devtools-core/package.json
+1 -1
@@ -5,7 +5,7 @@
5 "license": "MIT",
6 "main": "./dist/backend.js",
7 "repository": {
8 - "url": "https://github.com/bvaughn/react-devtools-experimental.git",
8 + "url": "https://github.com/facebook/react.git",
9 "type": "git"
10 },
11 "files": [
packages/react-devtools-inline/package.json
+1 -1
@@ -5,7 +5,7 @@
5 "license": "MIT",
6 "main": "./dist/backend.js",
7 "repository": {
8 - "url": "https://github.com/bvaughn/react-devtools-experimental.git",
8 + "url": "https://github.com/facebook/react.git",
9 "type": "git"
10 },
11 "files": [
packages/react-devtools/package.json
+1 -1
@@ -4,7 +4,7 @@
4 "description": "Use react-devtools outside of the browser",
5 "license": "MIT",
6 "repository": {
7 - "url": "https://github.com/bvaughn/react-devtools-experimental.git",
7 + "url": "https://github.com/facebook/react.git",
8 "type": "git"
9 },
10 "bin": {
shells/browser/shared/deploy.html
+3 -4
@@ -18,12 +18,11 @@
18
19 <h3>
20 Created on <strong>%date%</strong> from
21 - <a href="http://github.com/bvaughn/react-devtools-experimental/commit/%commit%"><code>%commit%</code></a>
21 + <a href="http://github.com/facebook/react/commit/%commit%"><code>%commit%</code></a>
22 </h3>
23
24 <p>
25 - This is a preview build of an <a href="https://github.com/bvaughn/react-devtools-experimental">unreleased DevTools extension</a>.
26 - It has no developer support.
25 + This is a preview build of the <a href="https://github.com/facebook/react">React DevTools extension</a>.
26 </p>
27
28 <h2>Installation instructions</h2>
@@ -34,7 +33,7 @@
33
34 <h2>Bug reports</h2>
35 <p>
37 - Please report bugs as <a href="https://github.com/bvaughn/react-devtools-experimental/issues/new?labels=bug">GitHub issues</a>.
36 + Please report bugs as <a href="https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools">GitHub issues</a>.
37 Please include all of the info required to reproduce the bug (e.g. links, code, instructions).
38 </p>
39
shells/utils.js
+7 -1
@@ -9,7 +9,12 @@ function getGitCommit() {
9 }
10
11 function getGitHubURL() {
12 - // TODO potentially replace this with an fb.me URL (assuming it can forward the query params)
12 + // HACK We are in the middle of migrating;
13 + // For now, forcefully direct people to the new repository-
14 + // even though we may be deploying from the old repo.
15 + return 'https://github.com/facebook/react';
16 +
17 + /* TODO potentially replace this with an fb.me URL (assuming it can forward the query params)
18 const url = execSync('git remote get-url origin')
19 .toString()
20 .trim();
@@ -22,6 +27,7 @@ function getGitHubURL() {
27 .replace('git@', 'https://')
28 .replace('.git', '');
29 }
30 + */
31 }
32
33 function getVersionString() {
src/constants.js
+1 -1
@@ -26,7 +26,7 @@ export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY =
26 export const PROFILER_EXPORT_VERSION = 4;
27
28 export const CHANGE_LOG_URL =
29 - 'https://github.com/bvaughn/react-devtools-experimental/blob/master/CHANGELOG.md';
29 + 'https://github.com/facebook/react/blob/master/packages/react-devtools/CHANGELOG.md';
30
31 // HACK
32 //
src/devtools/views/ErrorBoundary.js
+1 -1
@@ -51,7 +51,7 @@ export default class ErrorBoundary extends Component<Props, State> {
51 let bugURL = process.env.GITHUB_URL;
52 if (bugURL) {
53 const title = `Error: "${errorMessage || ''}"`;
54 - const label = '😭 bug';
54 + const label = 'Component: Developer Tools';
55
56 let body = '<!-- please provide repro information here -->\n';
57 body += '\n---------------------------------------------';