[Flare] Move click handling back into target phase (#15993)
Dominic Gannaway committed
Jun 26, 2019 at 20:44 UTC
dd93357aa073e4cf783475832ec7e354f108d822
1 file changed
+9
-4
packages/react-events/src/dom/Press.js
+9
-4
@@ -127,9 +127,10 @@ const targetEventTypes = [
127
// We need to preventDefault on pointerdown for mouse/pen events
128
// that are in hit target area but not the element area.
129
{name: 'pointerdown', passive: false},
130
+ {name: 'click', passive: false},
131
];
132
const rootEventTypes = [
132
- {name: 'click', passive: false},
133
+ 'click',
134
'keyup',
135
'pointerup',
136
'pointermove',
@@ -811,6 +812,13 @@ const PressResponder: ReactDOMEventResponder = {
812
removeRootEventTypes(context, state);
813
break;
814
}
815
+
816
+ case 'click': {
817
+ if (state.shouldPreventClick) {
818
+ nativeEvent.preventDefault();
819
+ }
820
+ break;
821
+ }
822
}
823
},
824
onRootEvent(
@@ -995,9 +1003,6 @@ const PressResponder: ReactDOMEventResponder = {
1003
if (state.pointerType !== 'keyboard') {
1004
removeRootEventTypes(context, state);
1005
}
998
- if (state.shouldPreventClick) {
999
- nativeEvent.preventDefault();
1000
- }
1006
break;
1007
}
1008