Renamed nativeHookIndex -> index
Brian Vaughn committed
Feb 21, 2019 at 08:59 UTC
e35819e68d46096b5e995a882baab2bfb05e2fcd
5 files changed
+14
-14
src/backend/ReactDebugHooks.js
+4
-4
@@ -225,7 +225,7 @@ type ReactCurrentDispatcher = {
225
};
226
227
type HooksNode = {
228
- nativeHookIndex: number,
228
+ index: number,
229
name: string,
230
value: mixed,
231
subHooks: Array<HooksNode>,
@@ -367,7 +367,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
367
const rootChildren = [];
368
let prevStack = null;
369
let levelChildren = rootChildren;
370
- let nativeHookIndex = 0;
370
+ let index = 0;
371
const stackOfChildren = [];
372
for (let i = 0; i < readHookLog.length; i++) {
373
const hook = readHookLog[i];
@@ -401,7 +401,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
401
levelChildren.push({
402
name: parseCustomHookName(stack[j - 1].functionName),
403
value: undefined,
404
- nativeHookIndex: -1,
404
+ index: -1,
405
subHooks: children,
406
});
407
stackOfChildren.push(levelChildren);
@@ -412,7 +412,7 @@ function buildTree(rootStack, readHookLog): HooksTree {
412
levelChildren.push({
413
name: hook.primitive,
414
value: hook.value,
415
- nativeHookIndex: hook.primitive === 'DebugValue' ? -1 : nativeHookIndex++,
415
+ index: hook.primitive === 'DebugValue' ? -1 : index++,
416
subHooks: [],
417
});
418
}
src/backend/agent.js
+3
-3
@@ -25,7 +25,7 @@ type InspectSelectParams = {|
25
26
type OverrideHookParams = {|
27
id: number,
28
- nativeHookIndex: number,
28
+ index: number,
29
path: Array<string | number>,
30
rendererID: number,
31
value: any,
@@ -133,7 +133,7 @@ export default class Agent extends EventEmitter {
133
134
overrideHook = ({
135
id,
136
- nativeHookIndex,
136
+ index,
137
path,
138
rendererID,
139
value,
@@ -142,7 +142,7 @@ export default class Agent extends EventEmitter {
142
if (renderer == null) {
143
console.warn(`Invalid renderer id "${rendererID}" for element "${id}"`);
144
} else {
145
- renderer.setInHook(id, nativeHookIndex, path, value);
145
+ renderer.setInHook(id, index, path, value);
146
}
147
};
148
src/backend/renderer.js
+2
-2
@@ -1168,14 +1168,14 @@ export function attach(
1168
1169
function setInHook(
1170
id: number,
1171
- nativeHookIndex: number,
1171
+ index: number,
1172
path: Array<string | number>,
1173
value: any
1174
) {
1175
const fiber = findCurrentFiberUsingSlowPath(idToFiberMap.get(id));
1176
if (fiber !== null) {
1177
if (typeof overrideHook === 'function') {
1178
- overrideHook(fiber, nativeHookIndex, path, value);
1178
+ overrideHook(fiber, index, path, value);
1179
}
1180
}
1181
}
src/backend/types.js
+3
-3
@@ -37,7 +37,7 @@ export type ReactRenderer = {
37
// 16.9+
38
overrideHook?: ?(
39
fiber: Object,
40
- nativeHookIndex: number,
40
+ index: number,
41
path: Array<string | number>,
42
value: any
43
) => void,
@@ -68,7 +68,7 @@ export type RendererInterface = {
68
setInContext: (id: number, path: Array<string | number>, value: any) => void,
69
setInHook: (
70
id: number,
71
- nativeHookIndex: number,
71
+ index: number,
72
path: Array<string | number>,
73
value: any
74
) => void,
@@ -99,7 +99,7 @@ export type DevToolsHook = {
99
};
100
101
export type HooksNode = {
102
- nativeHookIndex: number,
102
+ index: number,
103
name: string,
104
value: mixed,
105
subHooks: Array<HooksNode>,
src/devtools/views/HooksTree.js
+2
-2
@@ -56,7 +56,7 @@ type HookViewProps = {|
56
|};
57
58
function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
59
- const { name, nativeHookIndex, subHooks, value } = hook;
59
+ const { name, index, subHooks, value } = hook;
60
61
const bridge = useContext(BridgeContext);
62
const store = useContext(StoreContext);
@@ -126,7 +126,7 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
126
const rendererID = store.getRendererIDForElement(id);
127
bridge.send('overrideHook', {
128
id,
129
- nativeHookIndex,
129
+ index,
130
path,
131
rendererID,
132
value,