@samitouri / QOS-React-2 / commits / e5d06e34b6

Revert "Clear more Fiber fields in detachFiber (#18556)" (#18562)

This reverts commit d48dbb824985166ecb7b2959db03090a8593dce0.

Dan Abramov committed Apr 9, 2020 at 20:45 UTC e5d06e34b6ef28fc4e7e92c054ab625898f7159f
2 files changed -8
packages/react-reconciler/src/ReactFiberCommitWork.new.js
-4
@@ -1118,7 +1118,6 @@ function detachFiber(fiber: Fiber) {
1118 // itself will be GC:ed when the parent updates the next time.
1119 fiber.return = null;
1120 fiber.child = null;
1121 - fiber.sibling = null;
1121 fiber.memoizedState = null;
1122 fiber.updateQueue = null;
1123 fiber.dependencies = null;
@@ -1128,9 +1127,6 @@ function detachFiber(fiber: Fiber) {
1127 fiber.pendingProps = null;
1128 fiber.memoizedProps = null;
1129 fiber.stateNode = null;
1131 - if (__DEV__) {
1132 - fiber._debugOwner = null;
1133 - }
1130 }
1131
1132 function emptyPortalContainer(current: Fiber) {
packages/react-reconciler/src/ReactFiberCommitWork.old.js
-4
@@ -1118,7 +1118,6 @@ function detachFiber(fiber: Fiber) {
1118 // itself will be GC:ed when the parent updates the next time.
1119 fiber.return = null;
1120 fiber.child = null;
1121 - fiber.sibling = null;
1121 fiber.memoizedState = null;
1122 fiber.updateQueue = null;
1123 fiber.dependencies = null;
@@ -1128,9 +1127,6 @@ function detachFiber(fiber: Fiber) {
1127 fiber.pendingProps = null;
1128 fiber.memoizedProps = null;
1129 fiber.stateNode = null;
1131 - if (__DEV__) {
1132 - fiber._debugOwner = null;
1133 - }
1130 }
1131
1132 function emptyPortalContainer(current: Fiber) {