Remove coverage options from package.json
They don't provide any value and since one of them isn't a valid config usage, it blurs the line. Instead just store these pieces in the tasks and write them to the temp config.
Paul O’Shannessy committed
Dec 22, 2015 at 11:14 UTC
e68e17503e3a24c84c57e24256bc9afa85710c99
2 files changed
+13
-13
grunt/tasks/jest.js
+13
-3
@@ -19,13 +19,22 @@ var tempConfigPath = path.join(buildPath, 'jest-config.json');
19
20
var config = require(path.join(rootPath, 'package.json')).jest;
21
22
+var collectCoverageOnlyFrom = {
23
+ 'src/**/*.js': {
24
+ ignore: [
25
+ 'src/**/__tests__/*.js',
26
+ 'src/shared/vendor/third_party/*.js',
27
+ 'src/test/*.js',
28
+ ],
29
+ },
30
+};
31
+
32
function getCollectCoverageOnlyFrom(callback) {
23
- var coverageFrom = config.collectCoverageOnlyFrom;
24
- var patterns = Object.keys((config.collectCoverage && coverageFrom) || {});
33
+ var patterns = Object.keys(collectCoverageOnlyFrom);
34
var result = {};
35
36
async.each(patterns, function(pattern) {
28
- var options = assign({ nodir: true }, coverageFrom[pattern]);
37
+ var options = assign({ nodir: true }, collectCoverageOnlyFrom[pattern]);
38
glob(pattern, options, function(err, files) {
39
(files || []).reduce(function(object, key) {
40
object[key] = true;
@@ -44,6 +53,7 @@ function getJestConfig(callback) {
53
getCollectCoverageOnlyFrom(function(err, data) {
54
callback(err, assign({}, config, {
55
rootDir: rootDir,
56
+ collectCoverage: true,
57
collectCoverageOnlyFrom: data,
58
}));
59
});
package.json
-10
@@ -57,16 +57,6 @@
57
"test": "jest"
58
},
59
"jest": {
60
- "collectCoverage": true,
61
- "collectCoverageOnlyFrom": {
62
- "src/**/*.js": {
63
- "ignore": [
64
- "src/**/__tests__/*.js",
65
- "src/shared/vendor/third_party/*.js",
66
- "src/test/*.js"
67
- ]
68
- }
69
- },
60
"modulePathIgnorePatterns": [
61
"/.module-cache/",
62
"/react/build/"