Fix www tests not running in prod (#18593)
I made a mistake when setting these up a while ago. Setting the NODE_ENV in the CircleCI config doesn't work because it's also set in the node script command. The number of test commands is getting out of control. Might need to fix it at some point. Not today for me.
Andrew Clark committed
Apr 13, 2020 at 15:53 UTC
f3f3d77c206b8d0d56216de06aec53d48d53cd6e
2 files changed
+13
-15
.circleci/config.yml
+11
-15
@@ -138,7 +138,7 @@ jobs:
138
RELEASE_CHANNEL: stable
139
command: yarn test-www-variant --maxWorkers=2
140
141
- RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www:
141
+ RELEASE_CHANNEL_stable_yarn_test_prod_www:
142
docker: *docker
143
environment: *environment
144
steps:
@@ -147,11 +147,10 @@ jobs:
147
- *run_yarn
148
- run:
149
environment:
150
- NODE_ENV: production
150
RELEASE_CHANNEL: stable
152
- command: yarn test-www --maxWorkers=2
151
+ command: yarn test-prod-www --maxWorkers=2
152
154
- RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www_variant:
153
+ RELEASE_CHANNEL_stable_yarn_test_prod_www_variant:
154
docker: *docker
155
environment: *environment
156
steps:
@@ -160,9 +159,8 @@ jobs:
159
- *run_yarn
160
- run:
161
environment:
163
- NODE_ENV: production
162
RELEASE_CHANNEL: stable
165
- command: yarn test-www-variant --maxWorkers=2
163
+ command: yarn test-prod-www-variant --maxWorkers=2
164
165
yarn_test_www:
166
docker: *docker
@@ -188,7 +186,7 @@ jobs:
186
RELEASE_CHANNEL: experimental
187
command: yarn test-www-variant --maxWorkers=2
188
191
- NODE_ENV_production_yarn_test_www:
189
+ yarn_test_prod_www:
190
docker: *docker
191
environment: *environment
192
steps:
@@ -197,11 +195,10 @@ jobs:
195
- *run_yarn
196
- run:
197
environment:
200
- NODE_ENV: production
198
RELEASE_CHANNEL: experimental
202
- command: yarn test-www --maxWorkers=2
199
+ command: yarn test-prod-www --maxWorkers=2
200
204
- NODE_ENV_production_yarn_test_www_variant:
201
+ yarn_test_prod_www_variant:
202
docker: *docker
203
environment: *environment
204
steps:
@@ -210,7 +207,6 @@ jobs:
207
- *run_yarn
208
- run:
209
environment:
213
- NODE_ENV: production
210
RELEASE_CHANNEL: experimental
211
command: yarn test-www-variant --maxWorkers=2
212
@@ -489,10 +485,10 @@ workflows:
485
- RELEASE_CHANNEL_stable_yarn_test_www_variant:
486
requires:
487
- setup
492
- - RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www:
488
+ - RELEASE_CHANNEL_stable_yarn_test_prod_www:
489
requires:
490
- setup
495
- - RELEASE_CHANNEL_stable_NODE_ENV_production_yarn_test_www_variant:
491
+ - RELEASE_CHANNEL_stable_yarn_test_prod_www_variant:
492
requires:
493
- setup
494
- RELEASE_CHANNEL_stable_yarn_build:
@@ -532,10 +528,10 @@ workflows:
528
- yarn_test_www_variant:
529
requires:
530
- setup
535
- - NODE_ENV_production_yarn_test_www:
531
+ - yarn_test_prod_www:
532
requires:
533
- setup
538
- - NODE_ENV_production_yarn_test_www_variant:
534
+ - yarn_test_prod_www_variant:
535
requires:
536
- setup
537
- yarn_build:
package.json
+2
@@ -110,6 +110,8 @@
110
"test": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source.js",
111
"test-www": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-www.js",
112
"test-www-variant": "cross-env NODE_ENV=development VARIANT=true jest --config ./scripts/jest/config.source-www.js",
113
+ "test-prod-www": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source-www.js",
114
+ "test-prod-www-variant": "cross-env NODE_ENV=production VARIANT=true jest --config ./scripts/jest/config.source-www.js",
115
"test-persistent": "cross-env NODE_ENV=development jest --config ./scripts/jest/config.source-persistent.js",
116
"debug-test-persistent": "cross-env NODE_ENV=development node --inspect-brk node_modules/jest/bin/jest.js --config ./scripts/jest/config.source-persistent.js --runInBand",
117
"test-prod": "cross-env NODE_ENV=production jest --config ./scripts/jest/config.source.js",