Fix boolean attributes as per HTML5 spec
jjt committed
Jan 31, 2014 at 15:52 UTC
f7949c1c23cc150cbf51155e0e479e26e53a37c4
2 files changed
+5
-2
src/dom/DOMPropertyOperations.js
+3
@@ -95,6 +95,9 @@ var DOMPropertyOperations = {
95
return '';
96
}
97
var attributeName = DOMProperty.getAttributeName[name];
98
+ if (DOMProperty.hasBooleanValue[name]) {
99
+ return escapeTextForBrowser(attributeName);
100
+ }
101
return processAttributeNameAndPrefix(attributeName) +
102
escapeTextForBrowser(value) + '"';
103
} else if (DOMProperty.isCustomAttribute(name)) {
src/dom/__tests__/DOMPropertyOperations-test.js
+2
-2
@@ -82,12 +82,12 @@ describe('DOMPropertyOperations', function() {
82
expect(DOMPropertyOperations.createMarkupForProperty(
83
'checked',
84
'simple'
85
- )).toBe('checked="simple"');
85
+ )).toBe('checked');
86
87
expect(DOMPropertyOperations.createMarkupForProperty(
88
'checked',
89
true
90
- )).toBe('checked="true"');
90
+ )).toBe('checked');
91
92
expect(DOMPropertyOperations.createMarkupForProperty(
93
'checked',