Always flushPassiveEffects before rendering
I mistakenly wrapped this in the revertPassiveEffectsChange feature flag. It should flush regardless of the flag.
Andrew Clark committed
May 15, 2019 at 18:11 UTC
f961050a376f2a0d1397fb8129ae0e7d4efa9b52
1 file changed
+1
-3
packages/react-reconciler/src/ReactFiberScheduler.js
+1
-3
@@ -755,9 +755,7 @@ function renderRoot(
755
return commitRoot.bind(null, root);
756
}
757
758
- if (!revertPassiveEffectsChange) {
759
- flushPassiveEffects();
760
- }
758
+ flushPassiveEffects();
759
760
// If the root or expiration time have changed, throw out the existing stack
761
// and prepare a fresh one. Otherwise we'll continue where we left off.