@samitouri / QOS-React-2 / commits / fa5adb3bc4

Release script no longer auto-updates peerDependencies react version (#11292)

* Release script ensures peer dep matches release major version, but otherwise no longer auto-updates them to exactly match the release version. * f

Brian Vaughn committed Oct 20, 2017 at 08:53 UTC fa5adb3bc44fae7ee97ad089f3e290be7153ed07
1 file changed +8 -1
scripts/release/build-commands/update-package-versions.js
+8 -1
@@ -42,8 +42,15 @@ const update = async ({cwd, dry, version}) => {
42 }
43
44 if (project !== 'react') {
45 - json.peerDependencies.react = `^${version}`;
45 + const peerVersion = json.peerDependencies.react.replace('^', '');
46 +
47 + // Release engineers can manually update minor and bugfix versions,
48 + // But we should ensure that major versions always match.
49 + if (semver.major(version) !== semver.major(peerVersion)) {
50 + json.peerDependencies.react = `^${semver.major(version)}.0.0`;
51 + }
52 }
53 +
54 await writeJson(path, json, {spaces: 2});
55 };
56 await Promise.all(projects.map(updateProjectPackage));