reversed line 54 (no-op message) in ReactUpdateQueue.js and added it to the line above
Edvin Erikson committed
Jun 4, 2015 at 21:47 UTC
fa9382654a44341963660c2433629b7040030842
3 files changed
+9
-10
src/renderers/shared/reconciler/ReactUpdateQueue.js
+1
-2
@@ -50,8 +50,7 @@ function getInternalInstanceReadyForUpdate(publicInstance, callerName) {
50
!callerName,
51
'%s(...): Can only update a mounted or mounting component. ' +
52
'This usually means you called %s() on an unmounted component. ' +
53
- 'Please check the code for the %s component. ' +
54
- 'This is a no-op.',
53
+ 'This is a no-op. Please check the code for the %s component.',
54
callerName,
55
callerName,
56
publicInstance.constructor.displayName
src/renderers/shared/reconciler/__tests__/ReactComponentLifeCycle-test.js
+2
-2
@@ -257,8 +257,8 @@ describe('ReactComponentLifeCycle', function() {
257
expect(console.error.argsForCall[0][0]).toBe(
258
'Warning: setState(...): Can only update a mounted or ' +
259
'mounting component. This usually means you called setState() on an ' +
260
- 'unmounted component. Please check the code for the ' +
261
- 'StatefulComponent component. This is a no-op.'
260
+ 'unmounted component. This is a no-op. Please check the code for the ' +
261
+ 'StatefulComponent component.'
262
);
263
});
264
src/renderers/shared/reconciler/__tests__/ReactCompositeComponent-test.js
+6
-6
@@ -277,8 +277,8 @@ describe('ReactCompositeComponent', function() {
277
expect(console.error.argsForCall[0][0]).toBe(
278
'Warning: forceUpdate(...): Can only update a mounted or ' +
279
'mounting component. This usually means you called forceUpdate() on an ' +
280
- 'unmounted component. Please check the code for the ' +
281
- 'Component component. This is a no-op.'
280
+ 'unmounted component. This is a no-op. Please check the code for the ' +
281
+ 'Component component.'
282
);
283
});
284
@@ -309,8 +309,8 @@ describe('ReactCompositeComponent', function() {
309
expect(console.error.argsForCall[0][0]).toBe(
310
'Warning: setState(...): Can only update a mounted or ' +
311
'mounting component. This usually means you called setState() on an ' +
312
- 'unmounted component. Please check the code for the ' +
313
- 'Component component. This is a no-op.'
312
+ 'unmounted component. This is a no-op. Please check the code for the ' +
313
+ 'Component component.'
314
);
315
});
316
@@ -374,8 +374,8 @@ describe('ReactCompositeComponent', function() {
374
expect(console.error.argsForCall[0][0]).toBe(
375
'Warning: setProps(...): Can only update a mounted or ' +
376
'mounting component. This usually means you called setProps() on an ' +
377
- 'unmounted component. Please check the code for the ' +
378
- 'Component component. This is a no-op.'
377
+ 'unmounted component. This is a no-op. Please check the code for the ' +
378
+ 'Component component.'
379
);
380
});
381