Enable part of Suspense test that was failing before
This PR fixes it.
Dan Abramov committed
Apr 16, 2019 at 16:47 UTC
fe21ee7ca0f143d05b09ac43914db0d744380e08
1 file changed
+43
-40
src/__tests__/store-test.js
+43
-40
@@ -555,45 +555,48 @@ describe('Store', () => {
555
}
556
}
557
558
- // TODO: fix the bugs
559
- // // 4. Verify we can update from each step to each step in fallback mode.
560
- // for (let i = 0; i < steps.length; i++) {
561
- // for (let j = 0; j < steps.length; j++) {
562
- // // Always start with a fresh container and steps[i].
563
- // container = document.createElement('div');
564
- // act(() => ReactDOM.render(
565
- // <Root>
566
- // <X />
567
- // <React.Suspense fallback={steps[i]}>
568
- // <Z />
569
- // <Never />
570
- // <Z />
571
- // </React.Suspense>
572
- // <Y />
573
- // </Root>,
574
- // container
575
- // ));
576
- // expect(print(store)).toEqual(snapshots[i]);
577
- // // Re-render with steps[j].
578
- // act(() => ReactDOM.render(
579
- // <Root>
580
- // <X />
581
- // <React.Suspense fallback={steps[j]}>
582
- // <Z />
583
- // <Never />
584
- // <Z />
585
- // </React.Suspense>
586
- // <Y />
587
- // </Root>,
588
- // container
589
- // ));
590
- // // Verify the successful transition to steps[j].
591
- // expect(print(store)).toEqual(snapshots[j]);
592
- // // Clean up after every iteration.
593
- // act(() => ReactDOM.unmountComponentAtNode(container));
594
- // expect(print(store)).toBe('');
595
- // }
596
- // }
558
+ // 4. Verify we can update from each step to each step in fallback mode.
559
+ for (let i = 0; i < steps.length; i++) {
560
+ for (let j = 0; j < steps.length; j++) {
561
+ // Always start with a fresh container and steps[i].
562
+ container = document.createElement('div');
563
+ act(() =>
564
+ ReactDOM.render(
565
+ <Root>
566
+ <X />
567
+ <React.Suspense fallback={steps[i]}>
568
+ <Z />
569
+ <Never />
570
+ <Z />
571
+ </React.Suspense>
572
+ <Y />
573
+ </Root>,
574
+ container
575
+ )
576
+ );
577
+ expect(print(store)).toEqual(snapshots[i]);
578
+ // Re-render with steps[j].
579
+ act(() =>
580
+ ReactDOM.render(
581
+ <Root>
582
+ <X />
583
+ <React.Suspense fallback={steps[j]}>
584
+ <Z />
585
+ <Never />
586
+ <Z />
587
+ </React.Suspense>
588
+ <Y />
589
+ </Root>,
590
+ container
591
+ )
592
+ );
593
+ // Verify the successful transition to steps[j].
594
+ expect(print(store)).toEqual(snapshots[j]);
595
+ // Clean up after every iteration.
596
+ act(() => ReactDOM.unmountComponentAtNode(container));
597
+ expect(print(store)).toBe('');
598
+ }
599
+ }
600
601
// 5. Verify we can update from each step to each step when moving primary -> fallback.
602
for (let i = 0; i < steps.length; i++) {
@@ -776,4 +779,4 @@ describe('Store', () => {
779
// TODO:
780
// Test Concurrent Mode
781
});
779
-});
\ No newline at end of file
782
+});