@samitouri / QOS-React-2 / commits / ff3f1fac65

[RN] Set enableOwnerStacks and enableUseDeferredValueInitialArg to false

In www, the experimental versions get a .modern.js or .classic.js prefix and get copied into the same folder. In RN, they don't seem to have .modern.js and .classic.js versions so they end up getting the same name. sebmarkbage's theory is that what happens is that they then override the file that was already there. So depending on if experimental or stable build finishes first you get a different version at the end. It doesn't make sense to use `__EXPERIMENTAL__` for flags in native-fb since there's no modern/classic split there. So that flag should just be hardcoded to true or false and then it doesn't matter which one finishes first. We don't support experimental builds in OSS RN neither so the same thing could happen with [`enableOwnerStacks`](https://github.com/facebook/react/blob/5dcf3ca8d45a276a8b4cee0cedd234967661ca35/packages/shared/forks/ReactFeatureFlags.native-oss.js#L60). You can see that the build errors in the previous PR but passes after these flag changes. ghstack-source-id: d10f37bcea0e485fdb4f136370c179999badd560 Pull Request resolved: https://github.com/facebook/react/pull/30322

Lauren Tan committed Jul 12, 2024 at 11:21 UTC ff3f1fac65e7b82efe3f90af42af1278bc6f1d5d
2 files changed +2 -2
packages/shared/forks/ReactFeatureFlags.native-oss.js
+1 -1
@@ -57,7 +57,7 @@ export const enableLegacyFBSupport = false;
57 export const enableLegacyHidden = false;
58 export const enableNoCloningMemoCache = false;
59 export const enableObjectFiber = false;
60 -export const enableOwnerStacks = __EXPERIMENTAL__;
60 +export const enableOwnerStacks = false;
61 export const enablePostpone = false;
62 export const enableReactTestRendererWarning = false;
63 export const enableRefAsProp = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
+1 -1
@@ -69,7 +69,7 @@ export const enableTaint = true;
69 export const enableTransitionTracing = false;
70 export const enableTrustedTypesIntegration = false;
71 export const enableUpdaterTracking = false;
72 -export const enableUseDeferredValueInitialArg = __EXPERIMENTAL__;
72 +export const enableUseDeferredValueInitialArg = true;
73 export const enableUseEffectEventHook = false;
74 export const enableUseMemoCacheHook = true;
75 export const favorSafetyOverHydrationPerf = true;