[fiber-debugger] Support undefined progressedPriority (#10375)
[fiber-debugger] Fix the debugger to match changes to Fiber
Rodrigo Pombo committed
Aug 4, 2017 at 15:45 UTC
07acd7db816e2be3c9fad0f911f9a331275c77c8
3 files changed
+4
-54
fixtures/fiber-debugger/src/App.js
-2
@@ -41,8 +41,6 @@ class App extends Component {
41
sibling: true,
42
return: false,
43
fx: false,
44
- progressedChild: false,
45
- progressedDel: false,
44
},
45
};
46
}
fixtures/fiber-debugger/src/Fibers.js
+4
-49
@@ -163,8 +163,6 @@ const strokes = {
163
sibling: 'darkgreen',
164
return: 'red',
165
fx: 'purple',
166
- progressedChild: 'cyan',
167
- progressedDel: 'brown',
166
};
167
168
function Edge(props) {
@@ -242,12 +240,10 @@ function formatPriority(priority) {
240
case 2:
241
return 'task';
242
case 3:
245
- return 'animation';
246
- case 4:
243
return 'hi-pri work';
248
- case 5:
244
+ case 4:
245
return 'lo-pri work';
250
- case 6:
246
+ case 5:
247
return 'offscreen work';
248
default:
249
throw new Error('Unknown priority.');
@@ -302,28 +298,17 @@ export default function Fibers({fibers, show, ...rest}) {
298
{fibers.currentIDs.indexOf(fiber.id) === -1
299
? <small>
300
{fiber.pendingWorkPriority !== 0 && [
305
- <span
306
- style={{
307
- fontWeight: fiber.pendingWorkPriority <=
308
- fiber.progressedPriority
309
- ? 'bold'
310
- : 'normal',
311
- }}
312
- key="span">
301
+ <span key="span">
302
Needs: {formatPriority(fiber.pendingWorkPriority)}
303
</span>,
304
<br key="br" />,
305
]}
317
- {fiber.progressedPriority !== 0 && [
318
- `Finished: ${formatPriority(fiber.progressedPriority)}`,
319
- <br key="br" />,
320
- ]}
306
{fiber.memoizedProps !== null &&
307
fiber.pendingProps !== null && [
308
fiber.memoizedProps === fiber.pendingProps
309
? 'Can reuse memoized.'
310
: 'Cannot reuse memoized.',
326
- <br />,
311
+ <br key="br" />,
312
]}
313
</small>
314
: <small>
@@ -341,16 +326,6 @@ export default function Fibers({fibers, show, ...rest}) {
326
key={`${fiber.id}-${fiber.child}-child`}>
327
child
328
</Edge>,
344
- fiber.progressedChild &&
345
- show.progressedChild &&
346
- <Edge
347
- source={fiber.id}
348
- target={fiber.progressedChild}
349
- kind="progressedChild"
350
- weight={1000}
351
- key={`${fiber.id}-${fiber.progressedChild}-pChild`}>
352
- pChild
353
- </Edge>,
329
fiber.sibling &&
330
show.sibling &&
331
<Edge
@@ -401,26 +376,6 @@ export default function Fibers({fibers, show, ...rest}) {
376
key={`${fiber.id}-${fiber.lastEffect}-lastEffect`}>
377
lastFx
378
</Edge>,
404
- fiber.progressedFirstDeletion &&
405
- show.progressedDel &&
406
- <Edge
407
- source={fiber.id}
408
- target={fiber.progressedFirstDeletion}
409
- kind="progressedDel"
410
- weight={100}
411
- key={`${fiber.id}-${fiber.progressedFirstDeletion}-pFD`}>
412
- pFDel
413
- </Edge>,
414
- fiber.progressedLastDeletion &&
415
- show.progressedDel &&
416
- <Edge
417
- source={fiber.id}
418
- target={fiber.progressedLastDeletion}
419
- kind="progressedDel"
420
- weight={100}
421
- key={`${fiber.id}-${fiber.progressedLastDeletion}-pLD`}>
422
- pLDel
423
- </Edge>,
379
fiber.alternate &&
380
show.alt &&
381
<Edge
fixtures/fiber-debugger/src/describeFibers.js
-3
@@ -63,9 +63,6 @@ export default function describeFibers(rootFiber, workInProgress) {
63
nextEffect: acknowledgeFiber(fiber.nextEffect),
64
firstEffect: acknowledgeFiber(fiber.firstEffect),
65
lastEffect: acknowledgeFiber(fiber.lastEffect),
66
- progressedChild: acknowledgeFiber(fiber.progressedChild),
67
- progressedFirstDeletion: acknowledgeFiber(fiber.progressedFirstDeletion),
68
- progressedLastDeletion: acknowledgeFiber(fiber.progressedLastDeletion),
66
alternate: acknowledgeFiber(fiber.alternate),
67
});
68
return id;