Log all errors to console.error by default (#21130)
Sebastian Markbåge committed
Mar 29, 2021 at 22:39 UTC
0853aab74dc8285401e62d1e490551ba3c96fd64
3 files changed
+22
-7
packages/react-client/src/__tests__/ReactFlight-test.js
+14
-5
@@ -156,10 +156,15 @@ describe('ReactFlight', () => {
156
return <div ref={ref} />;
157
}
158
159
- const event = ReactNoopFlightServer.render(<EventHandlerProp />);
160
- const fn = ReactNoopFlightServer.render(<FunctionProp />);
161
- const symbol = ReactNoopFlightServer.render(<SymbolProp />);
162
- const refs = ReactNoopFlightServer.render(<RefProp />);
159
+ const options = {
160
+ onError() {
161
+ // ignore
162
+ },
163
+ };
164
+ const event = ReactNoopFlightServer.render(<EventHandlerProp />, options);
165
+ const fn = ReactNoopFlightServer.render(<FunctionProp />, options);
166
+ const symbol = ReactNoopFlightServer.render(<SymbolProp />, options);
167
+ const refs = ReactNoopFlightServer.render(<RefProp />, options);
168
169
function Client({transport}) {
170
return ReactNoopFlightClient.read(transport);
@@ -213,7 +218,11 @@ describe('ReactFlight', () => {
218
);
219
}
220
216
- const data = ReactNoopFlightServer.render(<Server />);
221
+ const data = ReactNoopFlightServer.render(<Server />, {
222
+ onError(x) {
223
+ // ignore
224
+ },
225
+ });
226
227
function Client({transport}) {
228
return ReactNoopFlightClient.read(transport);
packages/react-server/src/ReactFizzServer.js
+5
-1
@@ -142,13 +142,17 @@ type Request = {
142
// 500 * 1024 / 8 * .8 * 0.5 / 2
143
const DEFAULT_PROGRESSIVE_CHUNK_SIZE = 12800;
144
145
+function defaultErrorHandler(error: mixed) {
146
+ console['error'](error); // Don't transform to our wrapper
147
+}
148
+
149
export function createRequest(
150
children: ReactNodeList,
151
destination: Destination,
152
responseState: ResponseState,
153
rootContext: FormatContext,
154
progressiveChunkSize: number = DEFAULT_PROGRESSIVE_CHUNK_SIZE,
151
- onError: (error: mixed) => void = noop,
155
+ onError: (error: mixed) => void = defaultErrorHandler,
156
onCompleteAll: () => void = noop,
157
onReadyToStream: () => void = noop,
158
): Request {
packages/react-server/src/ReactFlightServer.js
+3
-1
@@ -91,7 +91,9 @@ export type Request = {
91
92
const ReactCurrentDispatcher = ReactSharedInternals.ReactCurrentDispatcher;
93
94
-function defaultErrorHandler() {}
94
+function defaultErrorHandler(error: mixed) {
95
+ console['error'](error); // Don't transform to our wrapper
96
+}
97
98
export function createRequest(
99
model: ReactModel,