@samitouri / QOS-React / commits / 0f050ad7cc

Make regression test better

Dan Abramov committed Aug 31, 2018 at 15:57 UTC 0f050ad7cccfc15323dc58c630dbc0963ff15285
1 file changed +2
packages/react-dom/src/__tests__/DOMPropertyOperations-test.js
+2
@@ -89,11 +89,13 @@ describe('DOMPropertyOperations', () => {
89 ReactDOM.render(
90 <select>
91 <option value="">empty</option>
92 + <option>filled</option>
93 </select>,
94 container,
95 );
96 // Regression test for https://github.com/facebook/react/issues/6219
97 expect(container.firstChild.firstChild.value).toBe('');
98 + expect(container.firstChild.lastChild.value).toBe('filled');
99 });
100
101 it('should remove for falsey boolean properties', () => {