Move 'lighthouse' and 'nodegit' to 'optionalDependencies' (#9675)
**what is the change?:** See title. **why make this change?:** Both these dependencies were causing issues when working on React internally at FB. 'lighthouse' requires node >=6 and we don't want to folks working on React to using that version of node. https://github.com/GoogleChrome/lighthouse/blob/master/package.json#L11 'nodegit' for me throws an error related to libssh2 and it's annoying to make this work in every OS. See https://github.com/nodegit/nodegit/issues/1266 **test plan:** `npm/yarn install` Runs with no errors on my CentOS machine and also on MacOSX laptop. **issue:** This is blocking work related to https://github.com/facebook/react/issues/9398
Flarnie Marchan committed
May 12, 2017 at 15:41 UTC
0f129973ea08cb142d4dc7d084fed91ec8a6527e
1 file changed
+4
-2
package.json
+4
-2
@@ -68,13 +68,11 @@
68
"jest-config": "^19.0.1",
69
"jest-jasmine2": "^19.0.1",
70
"jest-runtime": "^19.0.1",
71
- "lighthouse": "^1.6.3",
71
"loose-envify": "^1.1.0",
72
"merge-stream": "^1.0.0",
73
"mime": "^1.3.4",
74
"minimist": "^1.2.0",
75
"ncp": "^2.0.0",
77
- "nodegit": "^0.18.0",
76
"object-assign": "^4.1.1",
77
"platform": "^1.1.0",
78
"prettier": "^1.2.2",
@@ -97,6 +95,10 @@
95
"uglifyify": "^3.0.1",
96
"yargs": "^6.3.0"
97
},
98
+ "optionalDependencies": {
99
+ "lighthouse": "^1.6.3",
100
+ "nodegit": "^0.18.0"
101
+ },
102
"devEngines": {
103
"node": "4.x || 5.x || 6.x || 7.x",
104
"npm": "2.x || 3.x || 4.x"