@samitouri / QOS-React / commits / 13e05b4237

Use separate feature flag for ReactTestRenderer (#8965)

The ReactDOMFeatureFlags is not reachable from the npm package since it is in a separate build so we need a separate one.

Sebastian Markbåge committed Feb 9, 2017 at 08:00 UTC 13e05b4237819c028515d6dedec9c2d21324a198
3 files changed +26 -2
scripts/jest/test-framework-setup.js
+6
@@ -22,6 +22,12 @@ jest.mock('ReactNativeFeatureFlags', () => {
22 useFiber: flags.useFiber || !!process.env.REACT_DOM_JEST_USE_FIBER,
23 });
24 });
25 +jest.mock('ReactTestRendererFeatureFlags', () => {
26 + const flags = require.requireActual('ReactTestRendererFeatureFlags');
27 + return Object.assign({}, flags, {
28 + useFiber: flags.useFiber || !!process.env.REACT_DOM_JEST_USE_FIBER,
29 + });
30 +});
31
32 // Error logging varies between Fiber and Stack;
33 // Rather than fork dozens of tests, mock the error-logging file by default.
src/renderers/testing/ReactTestRenderer.js
+2 -2
@@ -11,8 +11,8 @@
11
12 'use strict';
13
14 -const ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
14 +const ReactTestRendererFeatureFlags = require('ReactTestRendererFeatureFlags');
15
16 -module.exports = ReactDOMFeatureFlags.useFiber
16 +module.exports = ReactTestRendererFeatureFlags.useFiber
17 ? require('ReactTestRendererFiber')
18 : require('ReactTestRendererStack');
src/renderers/testing/ReactTestRendererFeatureFlags.js new
+18
@@ -0,0 +1,18 @@
1 +/**
2 + * Copyright 2013-present, Facebook, Inc.
3 + * All rights reserved.
4 + *
5 + * This source code is licensed under the BSD-style license found in the
6 + * LICENSE file in the root directory of this source tree. An additional grant
7 + * of patent rights can be found in the PATENTS file in the same directory.
8 + *
9 + * @providesModule ReactTestRendererFeatureFlags
10 + */
11 +
12 +'use strict';
13 +
14 +var ReactTestRendererFeatureFlags = {
15 + useFiber: false,
16 +};
17 +
18 +module.exports = ReactTestRendererFeatureFlags;