@samitouri / QOS-React / commits / 16bf429029

Fix fiber feature flag for ReactDOMProduction-test (#8451)

Ben Alpert committed Nov 28, 2016 at 23:36 UTC 16bf42902926dd401206d8cff5ad61c0d7d49c96
5 files changed +12 -4
scripts/fiber/tests-failing.txt
+3
@@ -24,6 +24,9 @@ src/renderers/art/__tests__/ReactART-test.js
24 * resolves refs before componentDidMount
25 * resolves refs before componentDidUpdate
26
27 +src/renderers/dom/__tests__/ReactDOMProduction-test.js
28 +* should throw with an error code in production
29 +
30 src/renderers/dom/shared/__tests__/ReactDOM-test.js
31 * throws in render() if the mount callback is not a function
32 * throws in render() if the update callback is not a function
scripts/fiber/tests-passing.txt
-1
@@ -490,7 +490,6 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js
490 * should use prod React
491 * should handle a simple flow
492 * should call lifecycle methods
493 -* should throw with an error code in production
493
494 src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js
495 * should render strings as children
src/isomorphic/classic/types/__tests__/ReactPropTypesProduction-test.js
+3 -1
@@ -22,7 +22,9 @@ describe('ReactPropTypesProduction', function() {
22 beforeEach(function() {
23 __DEV__ = false;
24 oldProcess = process;
25 - global.process = {env: {NODE_ENV: 'production'}};
25 + global.process = {
26 + env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
27 + };
28
29 jest.resetModuleRegistry();
30 PropTypes = require('ReactPropTypes');
src/renderers/dom/__tests__/ReactDOMProduction-test.js
+3 -1
@@ -19,7 +19,9 @@ describe('ReactDOMProduction', () => {
19 beforeEach(() => {
20 __DEV__ = false;
21 oldProcess = process;
22 - global.process = {env: {NODE_ENV: 'production'}};
22 + global.process = {
23 + env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
24 + };
25
26 jest.resetModuleRegistry();
27 React = require('React');
src/renderers/shared/utils/__tests__/ReactErrorUtils-test.js
+3 -1
@@ -60,7 +60,9 @@ describe('ReactErrorUtils', () => {
60 );
61 __DEV__ = false;
62 var oldProcess = process;
63 - global.process = {env: {NODE_ENV: 'production'}};
63 + global.process = {
64 + env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
65 + };
66 jest.resetModuleRegistry();
67 ReactErrorUtils = require('ReactErrorUtils');
68 expect(ReactErrorUtils.invokeGuardedCallback).toEqual(