@samitouri / QOS-React / commits / 1d3558965f

Disable deferRenderPhaseUpdateToNextBatch by default (#21605)

We're still experimenting with this and it causes a breaking behavior for setState in componentWillMount/componentWillReceiveProps atm.

Sebastian Markbåge committed Jun 2, 2021 at 14:28 UTC 1d3558965f691ca8c01387e5b620fd7263fbcd19
8 files changed +8 -8
packages/shared/ReactFeatureFlags.js
+1 -1
@@ -158,7 +158,7 @@ export const enableLegacyFBSupport = false;
158 // not currently rendering. We treat them the same as if they came from an
159 // interleaved event. Remove this flag once we have migrated to the
160 // new behavior.
161 -export const deferRenderPhaseUpdateToNextBatch = true;
161 +export const deferRenderPhaseUpdateToNextBatch = false;
162
163 export const enableUseRefAccessWarning = false;
164
packages/shared/forks/ReactFeatureFlags.native-fb.js
+1 -1
@@ -50,7 +50,7 @@ export const deletedTreeCleanUpLevel = 1;
50 export const enableSuspenseLayoutEffectSemantics = false;
51
52 export const enableNewReconciler = false;
53 -export const deferRenderPhaseUpdateToNextBatch = true;
53 +export const deferRenderPhaseUpdateToNextBatch = false;
54
55 export const enableStrictEffects = __DEV__;
56 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = false;
55 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = false;
55 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = false;
55 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = true;
55 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.testing.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = false;
55 export const createRootStrictEffectsByDefault = false;
packages/shared/forks/ReactFeatureFlags.testing.www.js
+1 -1
@@ -49,7 +49,7 @@ export const deletedTreeCleanUpLevel = 1;
49 export const enableSuspenseLayoutEffectSemantics = false;
50
51 export const enableNewReconciler = false;
52 -export const deferRenderPhaseUpdateToNextBatch = true;
52 +export const deferRenderPhaseUpdateToNextBatch = false;
53
54 export const enableStrictEffects = false;
55 export const createRootStrictEffectsByDefault = false;