Fix unnecessary ReactDOM require (#9534)
Apparently, when you mark something as external in Rollup, a require statement is inserted even if the module isn't used. This is causing ReactDOM and several other modules to be inserted unnecessarily. We need a better fix for this, but I'm pushing this quick fix for now since it's blocking sync to www.
Andrew Clark committed
Apr 26, 2017 at 18:07 UTC
1fd582ba208e0679b7cc2c5d233df607f52b9e84
1 file changed
+3
-1
scripts/rollup/modules.js
+3
-1
@@ -164,7 +164,9 @@ function getExternalModules(externals, bundleType, isRenderer) {
164
externalModules.push('ReactCurrentOwner');
165
if (isRenderer) {
166
externalModules.push('React');
167
- externalModules.push('ReactDOM');
167
+ if (externalModules.includes('react-dom')) {
168
+ externalModules.push('ReactDOM');
169
+ }
170
}
171
break;
172
}