Add two event system cleanup TODOs (#26678)
There is so much old stuff in these files. I am weeping.
Sophie Alpert committed
Apr 19, 2023 at 18:41 UTC
22d5942675fcbd8b15b532284b49db4cb00d7144
1 file changed
+4
packages/react-dom-bindings/src/events/plugins/SimpleEventPlugin.js
+4
@@ -72,6 +72,8 @@ function extractEvents(
72
// Firefox creates a keypress event for function keys too. This removes
73
// the unwanted keypress events. Enter is however both printable and
74
// non-printable. One would expect Tab to be as well (but it isn't).
75
+ // TODO: Fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=968056. Can
76
+ // probably remove.
77
if (getEventCharCode(((nativeEvent: any): KeyboardEvent)) === 0) {
78
return;
79
}
@@ -95,6 +97,8 @@ function extractEvents(
97
case 'click':
98
// Firefox creates a click event on right mouse clicks. This removes the
99
// unwanted click events.
100
+ // TODO: Fixed in https://phabricator.services.mozilla.com/D26793. Can
101
+ // probably remove.
102
if (nativeEvent.button === 2) {
103
return;
104
}