@samitouri / QOS-React / commits / 278199b3de

Add ReactDOMClient to ServerIntegrationBasic (#28133)

## Overview Branched off https://github.com/facebook/react/pull/28130 In `hydrateRoot`, we now error if you pass `undefined`: ``` Warning: Must provide initial children as second argument to hydrateRoot. ``` So we expect 1 error for this now.

Ricky committed Feb 1, 2024 at 18:32 UTC 278199b3deeee73f969a242c777c2d38406f8bfe
1 file changed +6 -4
packages/react-dom/src/__tests__/ReactDOMServerIntegrationBasic-test.js
+6 -4
@@ -15,7 +15,7 @@ const ReactDOMServerIntegrationUtils = require('./utils/ReactDOMServerIntegratio
15 const TEXT_NODE_TYPE = 3;
16
17 let React;
18 -let ReactDOM;
18 +let ReactDOMClient;
19 let ReactDOMServer;
20 let ReactTestUtils;
21
@@ -23,13 +23,13 @@ function initModules() {
23 // Reset warning cache.
24 jest.resetModules();
25 React = require('react');
26 - ReactDOM = require('react-dom');
26 + ReactDOMClient = require('react-dom/client');
27 ReactDOMServer = require('react-dom/server');
28 ReactTestUtils = require('react-dom/test-utils');
29
30 // Make them available to the helpers.
31 return {
32 - ReactDOM,
32 + ReactDOMClient,
33 ReactDOMServer,
34 ReactTestUtils,
35 };
@@ -149,8 +149,10 @@ describe('ReactDOMServerIntegration', () => {
149 expect(await render([])).toBe(null);
150 expect(await render(false)).toBe(null);
151 expect(await render(true)).toBe(null);
152 - expect(await render(undefined)).toBe(null);
152 expect(await render([[[false]], undefined])).toBe(null);
153 +
154 + // hydrateRoot errors for undefined children.
155 + expect(await render(undefined, 1)).toBe(null);
156 });
157 });
158 });