Clean up the enableEarlyReturnForPropDiffing experiment (#29041)
## Summary The experiment has shown no significant performance changes. This PR removes it. ## How did you test this change? ``` yarn flow native yarn lint ```
Dmytro Rykun committed
May 10, 2024 at 11:00 UTC
2c022b847ed2171c59d37db9f71b394e0082ae3f
10 files changed
-22
packages/react-native-renderer/src/ReactNativeAttributePayload.js
-7
@@ -14,8 +14,6 @@ import {
14
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
15
import isArray from 'shared/isArray';
16
17
-import {enableEarlyReturnForPropDiffing} from 'shared/ReactFeatureFlags';
18
-
17
import type {AttributeConfiguration} from './ReactNativeTypes';
18
19
const emptyObject = {};
@@ -485,11 +483,6 @@ export function diff(
483
nextProps: Object,
484
validAttributes: AttributeConfiguration,
485
): null | Object {
488
- if (enableEarlyReturnForPropDiffing) {
489
- if (prevProps === nextProps) {
490
- return null; // no change
491
- }
492
- }
486
return diffProperties(
487
null, // updatePayload
488
prevProps,
packages/react-native-renderer/src/ReactNativeAttributePayloadFabric.js
-6
@@ -14,7 +14,6 @@ import {
14
} from 'react-native/Libraries/ReactPrivate/ReactNativePrivateInterface';
15
import isArray from 'shared/isArray';
16
17
-import {enableEarlyReturnForPropDiffing} from 'shared/ReactFeatureFlags';
17
import {enableAddPropertiesFastPath} from 'shared/ReactFeatureFlags';
18
19
import type {AttributeConfiguration} from './ReactNativeTypes';
@@ -551,11 +550,6 @@ export function diff(
550
nextProps: Object,
551
validAttributes: AttributeConfiguration,
552
): null | Object {
554
- if (enableEarlyReturnForPropDiffing) {
555
- if (prevProps === nextProps) {
556
- return null; // no change
557
- }
558
- }
553
return diffProperties(
554
null, // updatePayload
555
prevProps,
packages/shared/ReactFeatureFlags.js
-2
@@ -121,8 +121,6 @@ export const passChildrenWhenCloningPersistedNodes = false;
121
122
export const enableServerComponentLogs = __EXPERIMENTAL__;
123
124
-export const enableEarlyReturnForPropDiffing = false;
125
-
124
export const enableAddPropertiesFastPath = false;
125
126
export const enableOwnerStacks = __EXPERIMENTAL__;
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -23,7 +23,6 @@ export const disableDefaultPropsExceptForClasses = __VARIANT__;
23
export const disableStringRefs = __VARIANT__;
24
export const enableAddPropertiesFastPath = __VARIANT__;
25
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
26
-export const enableEarlyReturnForPropDiffing = __VARIANT__;
26
export const enableFastJSX = __VARIANT__;
27
export const enableInfiniteRenderLoopDetection = __VARIANT__;
28
export const enableRefAsProp = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -25,7 +25,6 @@ export const {
25
disableStringRefs,
26
enableAddPropertiesFastPath,
27
enableDeferRootSchedulingToMicrotask,
28
- enableEarlyReturnForPropDiffing,
28
enableFastJSX,
29
enableInfiniteRenderLoopDetection,
30
enableRefAsProp,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -101,7 +101,6 @@ export const allowConcurrentByDefault = false;
101
export const enableTransitionTracing = false;
102
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
103
export const passChildrenWhenCloningPersistedNodes = false;
104
-export const enableEarlyReturnForPropDiffing = false;
104
export const enableAsyncIterableChildren = false;
105
export const enableAddPropertiesFastPath = false;
106
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -76,7 +76,6 @@ export const disableClientCache = true;
76
77
export const enableServerComponentLogs = true;
78
export const enableInfiniteRenderLoopDetection = false;
79
-export const enableEarlyReturnForPropDiffing = false;
79
export const enableAddPropertiesFastPath = false;
80
81
export const renameElementSymbol = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -88,7 +88,6 @@ export const disableLegacyMode = false;
88
export const disableDOMTestUtils = false;
89
90
export const disableDefaultPropsExceptForClasses = false;
91
-export const enableEarlyReturnForPropDiffing = false;
91
export const enableAddPropertiesFastPath = false;
92
93
export const renameElementSymbol = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -88,7 +88,6 @@ export const disableLegacyMode = false;
88
export const disableDOMTestUtils = false;
89
90
export const disableDefaultPropsExceptForClasses = false;
91
-export const enableEarlyReturnForPropDiffing = false;
91
export const enableAddPropertiesFastPath = false;
92
93
export const renameElementSymbol = false;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -121,7 +121,6 @@ export const disableStringRefs = false;
121
export const disableLegacyMode = __EXPERIMENTAL__;
122
123
export const disableDOMTestUtils = false;
124
-export const enableEarlyReturnForPropDiffing = false;
124
125
export const enableOwnerStacks = false;
126