Remove unused unmountIDFromEnvironment (#7259)
I got rid of the need for this a few months ago.
Ben Alpert committed
Jul 25, 2016 at 23:34 UTC
30aa84181d98dc9498f7e1eb3ded817d8faf65f6
4 files changed
-31
src/renderers/dom/shared/ReactComponentBrowserEnvironment.js
-10
@@ -27,16 +27,6 @@ var ReactComponentBrowserEnvironment = {
27
replaceNodeWithMarkup:
28
DOMChildrenOperations.dangerouslyReplaceNodeWithMarkup,
29
30
- /**
31
- * If a particular environment requires that some resources be cleaned up,
32
- * specify this in the injected Mixin. In the DOM, we would likely want to
33
- * purge any cached node ID lookups.
34
- *
35
- * @private
36
- */
37
- unmountIDFromEnvironment: function(rootNodeID) {
38
- },
39
-
30
};
31
32
module.exports = ReactComponentBrowserEnvironment;
src/renderers/dom/shared/ReactDOMComponent.js
-3
@@ -23,8 +23,6 @@ var EventConstants = require('EventConstants');
23
var EventPluginHub = require('EventPluginHub');
24
var EventPluginRegistry = require('EventPluginRegistry');
25
var ReactBrowserEventEmitter = require('ReactBrowserEventEmitter');
26
-var ReactComponentBrowserEnvironment =
27
- require('ReactComponentBrowserEnvironment');
26
var ReactDOMButton = require('ReactDOMButton');
27
var ReactDOMComponentFlags = require('ReactDOMComponentFlags');
28
var ReactDOMComponentTree = require('ReactDOMComponentTree');
@@ -1212,7 +1210,6 @@ ReactDOMComponent.Mixin = {
1210
this.unmountChildren(safely);
1211
ReactDOMComponentTree.uncacheNode(this);
1212
EventPluginHub.deleteAllListeners(this);
1215
- ReactComponentBrowserEnvironment.unmountIDFromEnvironment(this._rootNodeID);
1213
this._rootNodeID = null;
1214
this._domID = null;
1215
this._wrapperState = null;
src/renderers/native/ReactNativeComponentEnvironment.js
-9
@@ -20,15 +20,6 @@ var ReactNativeComponentEnvironment = {
20
21
replaceNodeWithMarkup: ReactNativeDOMIDOperations.dangerouslyReplaceNodeWithMarkupByID,
22
23
- /**
24
- * Nothing to do for UIKit bridge.
25
- *
26
- * @private
27
- */
28
- unmountIDFromEnvironment: function(/*rootNodeID*/) {
29
-
30
- },
31
-
23
/**
24
* @param {DOMElement} Element to clear.
25
*/
src/renderers/shared/stack/reconciler/ReactComponentEnvironment.js
-9
@@ -17,13 +17,6 @@ var injected = false;
17
18
var ReactComponentEnvironment = {
19
20
- /**
21
- * Optionally injectable environment dependent cleanup hook. (server vs.
22
- * browser etc). Example: A browser system caches DOM nodes based on component
23
- * ID and must remove that cache entry when this instance is unmounted.
24
- */
25
- unmountIDFromEnvironment: null,
26
-
20
/**
21
* Optionally injectable hook for swapping out mount images in the middle of
22
* the tree.
@@ -42,8 +35,6 @@ var ReactComponentEnvironment = {
35
!injected,
36
'ReactCompositeComponent: injectEnvironment() can only be called once.'
37
);
45
- ReactComponentEnvironment.unmountIDFromEnvironment =
46
- environment.unmountIDFromEnvironment;
38
ReactComponentEnvironment.replaceNodeWithMarkup =
39
environment.replaceNodeWithMarkup;
40
ReactComponentEnvironment.processChildrenUpdates =