@samitouri / QOS-React / commits / 3322f6bf31

Re-add haste modules for ReactTypes and ReactNativeRTTypes shims (#11557)

* Re-add haste module for ReactNativeRTTypes * Re-added ReactTypes @providesModule annotation as well * Updated expected provides modules list * Improved clarity of check_modules.sh error message * Added ReactTypes to provides module whitelist

Brian Vaughn committed Nov 15, 2017 at 08:17 UTC 3322f6bf31b5c2fe724eae039b28d5a893fe3cd7
3 files changed +9 -1
packages/react-rt-renderer/src/ReactNativeRTTypes.js
+1
@@ -5,6 +5,7 @@
5 * LICENSE file in the root directory of this source tree.
6 *
7 * @flow
8 + * @providesModule ReactNativeRTTypes
9 */
10
11 /**
packages/shared/ReactTypes.js
+1
@@ -5,6 +5,7 @@
5 * LICENSE file in the root directory of this source tree.
6 *
7 * @flow
8 + * @providesModule ReactTypes
9 */
10
11 export type ReactNode =
scripts/circleci/check_modules.sh
+7 -1
@@ -5,11 +5,17 @@ set -e
5 # Make sure we don't introduce accidental @providesModule annotations.
6 EXPECTED='packages/react-cs-renderer/src/ReactNativeCSTypes.js
7 packages/react-native-renderer/src/ReactNativeTypes.js
8 +packages/react-rt-renderer/src/ReactNativeRTTypes.js
9 +packages/shared/ReactTypes.js
10 scripts/rollup/wrappers.js'
11 ACTUAL=$(git grep -l @providesModule -- './*.js' ':!scripts/rollup/shims/*.js')
12
13 +# Colors
14 +red=$'\e[1;31m'
15 +end=$'\e[0m'
16 +
17 if [ "$EXPECTED" != "$ACTUAL" ]; then
12 - echo "@providesModule crept into some new files?"
18 + printf "%s\n" "${red}ERROR: @providesModule crept into some new files?${end}"
19 diff -u <(echo "$EXPECTED") <(echo "$ACTUAL") || true
20 exit 1
21 fi