[Fiber] Assign ReactTypeOfSideEffect to ReactFiber.Fiber.effectTag correctly (#8173)
The type of `ReactFiber.Fiber.effectTag` is `TypeOfSideEffect`. Thus we should assign `ReactTypeOfSideEffect.NoEffect` value instead of `ReactPriorityLevel.NoWork` even if they are same values.
Tetsuharu OHZEKI committed
Nov 2, 2016 at 08:24 UTC
33ac5e8e4b48f369c51074254a20b3f453840699
2 files changed
+3
-7
src/renderers/shared/fiber/ReactChildFiber.js
+2
-6
@@ -23,7 +23,6 @@ var {
23
} = require('ReactCoroutine');
24
25
var ReactFiber = require('ReactFiber');
26
-var ReactPriorityLevel = require('ReactPriorityLevel');
26
var ReactReifiedYield = require('ReactReifiedYield');
27
var ReactTypeOfSideEffect = require('ReactTypeOfSideEffect');
28
var ReactTypeOfWork = require('ReactTypeOfWork');
@@ -56,10 +55,7 @@ const {
55
} = ReactTypeOfWork;
56
57
const {
59
- NoWork,
60
-} = ReactPriorityLevel;
61
-
62
-const {
58
+ NoEffect,
59
Placement,
60
Deletion,
61
} = ReactTypeOfSideEffect;
@@ -179,7 +175,7 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {
175
// we're reconciling at a lower priority that means that this was
176
// down-prioritized.
177
fiber.pendingWorkPriority = priority;
182
- fiber.effectTag = NoWork;
178
+ fiber.effectTag = NoEffect;
179
fiber.index = 0;
180
fiber.sibling = null;
181
return fiber;
src/renderers/shared/fiber/ReactFiberScheduler.js
+1
-1
@@ -137,7 +137,7 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) {
137
commitInsertion(effectfulFiber);
138
// Clear the effect tag so that we know that this is inserted, before
139
// any life-cycles like componentDidMount gets called.
140
- effectfulFiber.effectTag = NoWork;
140
+ effectfulFiber.effectTag = NoEffect;
141
break;
142
}
143
case PlacementAndUpdate: {