@samitouri / QOS-React / commits / 3b597c0576

Clean up findFiberByHostInstance from DevTools Hook (#31711)

The need for this was removed in https://github.com/facebook/react/pull/30831 Since the new DevTools version has been released for a while and we expect people to more or less auto-update. Future versions of React don't need this. Once we remove the remaining uses of `getInstanceFromNode` e.g. in the deprecated internal `findDOMNode`/`findNodeHandle` and the event system, we can completely remove the tagging of DOM nodes.

Sebastian Markbåge committed Dec 10, 2024 at 11:24 UTC 3b597c0576977773910c77e075cc6d6308decb04
1 file changed -2
packages/react-reconciler/src/ReactFiberReconciler.js
-2
@@ -42,7 +42,6 @@ import {enableSchedulingProfiler} from 'shared/ReactFeatureFlags';
42 import ReactSharedInternals from 'shared/ReactSharedInternals';
43 import {
44 getPublicInstance,
45 - getInstanceFromNode,
45 rendererVersion,
46 rendererPackageName,
47 extraDevToolsConfig,
@@ -847,7 +846,6 @@ export function injectIntoDevTools(): boolean {
846 version: rendererVersion,
847 rendererPackageName: rendererPackageName,
848 currentDispatcherRef: ReactSharedInternals,
850 - findFiberByHostInstance: getInstanceFromNode,
849 // Enables DevTools to detect reconciler version rather than renderer version
850 // which may not match for third party renderers.
851 reconcilerVersion: ReactVersion,