Break up require/import statements in strings (#18222)
Christoph Nakazawa committed
Mar 5, 2020 at 22:27 UTC
4027f2a3b82ecc325224f7827fc2c8e71a284279
2 files changed
+15
-5
packages/react-reconciler/src/ReactFiberWorkLoop.js
+12
-4
@@ -2937,11 +2937,15 @@ export function warnIfNotScopedWithMatchingAct(fiber: Fiber): void {
2937
"It looks like you're using the wrong act() around your test interactions.\n" +
2938
'Be sure to use the matching version of act() corresponding to your renderer:\n\n' +
2939
'// for react-dom:\n' +
2940
- "import {act} from 'react-dom/test-utils';\n" +
2940
+ // Break up imports to avoid accidentally parsing them as dependencies.
2941
+ 'import {act} fr' +
2942
+ "om 'react-dom/test-utils';\n" +
2943
'// ...\n' +
2944
'act(() => ...);\n\n' +
2945
'// for react-test-renderer:\n' +
2944
- "import TestRenderer from 'react-test-renderer';\n" +
2946
+ // Break up imports to avoid accidentally parsing them as dependencies.
2947
+ 'import TestRenderer fr' +
2948
+ "om react-test-renderer';\n" +
2949
'const {act} = TestRenderer;\n' +
2950
'// ...\n' +
2951
'act(() => ...);' +
@@ -3027,7 +3031,9 @@ export function warnIfUnmockedScheduler(fiber: Fiber) {
3031
'In Concurrent or Sync modes, the "scheduler" module needs to be mocked ' +
3032
'to guarantee consistent behaviour across tests and browsers. ' +
3033
'For example, with jest: \n' +
3030
- "jest.mock('scheduler', () => require('scheduler/unstable_mock'));\n\n" +
3034
+ // Break up requires to avoid accidentally parsing them as dependencies.
3035
+ "jest.mock('scheduler', () => require" +
3036
+ "('scheduler/unstable_mock'));\n\n" +
3037
'For more info, visit https://fb.me/react-mock-scheduler',
3038
);
3039
} else if (warnAboutUnmockedScheduler === true) {
@@ -3036,7 +3042,9 @@ export function warnIfUnmockedScheduler(fiber: Fiber) {
3042
'Starting from React v17, the "scheduler" module will need to be mocked ' +
3043
'to guarantee consistent behaviour across tests and browsers. ' +
3044
'For example, with jest: \n' +
3039
- "jest.mock('scheduler', () => require('scheduler/unstable_mock'));\n\n" +
3045
+ // Break up requires to avoid accidentally parsing them as dependencies.
3046
+ "jest.mock('scheduler', () => require" +
3047
+ "('scheduler/unstable_mock'));\n\n" +
3048
'For more info, visit https://fb.me/react-mock-scheduler',
3049
);
3050
}
packages/shared/ReactLazyComponent.js
+3
-1
@@ -50,7 +50,9 @@ export function initializeLazyComponentType(
50
console.error(
51
'lazy: Expected the result of a dynamic import() call. ' +
52
'Instead received: %s\n\nYour code should look like: \n ' +
53
- "const MyComponent = lazy(() => import('./MyComponent'))",
53
+ // Break up imports to avoid accidentally parsing them as dependencies.
54
+ 'const MyComponent = lazy(() => imp' +
55
+ "ort('./MyComponent'))",
56
moduleObject,
57
);
58
}