Change ReactVersion from CJS to ES module (#18181)
Sebastian Markbåge committed
Feb 28, 2020 at 13:09 UTC
4469700bb60ffd62caf112e47bcfa51afdd40e47
4 files changed
+10
-10
packages/shared/ReactVersion.js
+1
-3
@@ -5,7 +5,5 @@
5
* LICENSE file in the root directory of this source tree.
6
*/
7
8
-'use strict';
9
-
8
// TODO: this is special because it gets imported during build.
11
-module.exports = '16.13.0';
9
+export default '16.13.0';
scripts/release/publish-commands/update-stable-version-numbers.js
+1
-1
@@ -44,7 +44,7 @@ const run = async ({cwd, packages, skipPackages, tags}) => {
44
const sourceReactVersion = readFileSync(
45
sourceReactVersionPath,
46
'utf8'
47
- ).replace(/module\.exports = '[^']+';/, `module.exports = '${version}';`);
47
+ ).replace(/export default '[^']+';/, `export default '${version}';`);
48
writeFileSync(sourceReactVersionPath, sourceReactVersion);
49
}
50
};
scripts/release/utils.js
+1
-4
@@ -209,10 +209,7 @@ const updateVersionsForNext = async (cwd, reactVersion, version) => {
209
const sourceReactVersion = readFileSync(
210
sourceReactVersionPath,
211
'utf8'
212
- ).replace(
213
- /module\.exports = '[^']+';/,
214
- `module.exports = '${reactVersion}';`
215
- );
212
+ ).replace(/export default '[^']+';/, `export default '${reactVersion}';`);
213
writeFileSync(sourceReactVersionPath, sourceReactVersion);
214
215
// Update the root package.json.
scripts/tasks/version-check.js
+7
-2
@@ -7,7 +7,12 @@
7
8
'use strict';
9
10
-const reactVersion = require('../../package.json').version;
10
+const fs = require('fs');
11
+const ReactVersionSrc = fs.readFileSync(
12
+ require.resolve('../../packages/shared/ReactVersion')
13
+);
14
+const reactVersion = /export default '([^']+)';/.exec(ReactVersionSrc)[1];
15
+
16
const versions = {
17
'packages/react/package.json': require('../../packages/react/package.json')
18
.version,
@@ -15,7 +20,7 @@ const versions = {
20
.version,
21
'packages/react-test-renderer/package.json': require('../../packages/react-test-renderer/package.json')
22
.version,
18
- 'packages/shared/ReactVersion.js': require('../../packages/shared/ReactVersion'),
23
+ 'packages/shared/ReactVersion.js': reactVersion,
24
};
25
26
let allVersionsMatch = true;