@samitouri / QOS-React / commits / 4845e16c22

[ci] Fix param casing (#32748)

Casing was incorrect. Tested by running locally with a PAT. ``` $ scripts/release/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 Command failed: gh attestation verify artifacts_combined.zip --repo=facebook/react Error: failed to fetch attestations from facebook/react: HTTP 404: Not Found (https://api.github.com/repos/facebook/react/attestations/sha256:23d05644f9e49e02cbb441e3932cc4366b261826e58ce222ea249a6b786f0b5f?per_page=30) `gh attestation verify artifacts_combined.zip --repo=facebook/react` (exited with error code 1) $ scripts/release/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 --noVerify ⠼ Downloading artifacts from GitHub for commit 2d40460cf768071d3a70b4cdc16075d23ca1ff25) 5% 0.1m, estimated 1.6m ✓ Downloading artifacts from GitHub for commit 2d40460cf768071d3a70b4cdc16075d23ca1ff25) 9.5 secs An experimental build has been downloaded! You can download this build again by running: scripts/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 ```

lauren committed Mar 25, 2025 at 16:05 UTC 4845e16c22caf27334a1eab712ed258a9ae09752
2 files changed +3 -3
.github/workflows/runtime_build_and_test.yml
+2 -2
@@ -487,7 +487,7 @@ jobs:
487 #
488 # Note that this means that scripts/release/download-experimental-build.js must be run with
489 # --no-verify when downloading a build from a fork.
490 - if: github.event.pull_request.head.repo.full_name == github.repository
490 + if: github.event_name == 'push' && github.ref_name == 'main' || github.event.pull_request.head.repo.full_name == github.repository
491 with:
492 subject-name: artifacts_combined.zip
493 subject-digest: sha256:${{ steps.upload_artifacts_combined.outputs.artifact-digest }}
@@ -818,7 +818,7 @@ jobs:
818 # unverified artifact is not used. Additionally this workflow runs in the pull_request
819 # trigger so only restricted permissions are available.
820 run: |
821 - GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=$(git rev-parse ${{ github.event.pull_request.base.sha }}) ${{ (github.event.pull_request.head.repo.full_name != github.repository && '--no-verify') || ''}}
821 + GH_TOKEN=${{ github.token }} scripts/release/download-experimental-build.js --commit=$(git rev-parse ${{ github.event.pull_request.base.sha }}) ${{ (github.event.pull_request.head.repo.full_name != github.repository && '--noVerify') || ''}}
822 mv ./build ./base-build
823 - name: Delete extraneous files
824 # TODO: The `download-experimental-build` script copies the npm
scripts/release/download-experimental-build.js
+1 -1
@@ -27,7 +27,7 @@ const argv = yargs.wrap(yargs.terminalWidth()).options({
27 demandOption: true,
28 type: 'string',
29 },
30 - 'no-verify': {
30 + noVerify: {
31 describe: 'Skip verification',
32 requiresArg: false,
33 type: 'boolean',