@samitouri / QOS-React / commits / 48b7b2c67c

Add note about potential future bugs

Sebastian Markbage committed Jul 18, 2016 at 17:41 UTC 48b7b2c67c96aec21b6c4150c6c3f80d481f709b
1 file changed +3
src/renderers/shared/fiber/ReactFiberCompleteWork.js
+3
@@ -47,6 +47,9 @@ module.exports = function<T, P, I, C>(config : HostConfig<T, P, I, C>) {
47 }
48
49 /*
50 + // TODO: It's possible this will create layout thrash issues because mutations
51 + // of the DOM and life-cycles are interleaved. E.g. if a componentDidMount
52 + // of a sibling reads, then the next sibling updates and reads etc.
53 function markForPostEffect(workInProgress : Fiber) {
54 // Schedule a side-effect on this fiber, AFTER the children's side-effects.
55 if (workInProgress.lastEffect) {